Closed
Bug 836285
Opened 11 years ago
Closed 6 years ago
Unhack JSM concatenation in /services
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect, P4)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: gps, Unassigned)
References
Details
(Whiteboard: [measurement:client])
In bug 834936 and bug 836177 we used preprocessor magic to concatenate JSMs together to load them in a single compartment so we wouldn't have so much memory overhead from multiple compartments. This is ugly and prone to subtle gotchas. As soon as zones lands we should unhack these changes (after veriyfing we don't regress memory too much, of course).
Updated•11 years ago
|
Priority: -- → P4
Reporter | ||
Updated•11 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Comment 1•11 years ago
|
||
Zones have landed now.
Reporter | ||
Comment 2•11 years ago
|
||
At various times I've attempted to unhack the concatenation. However, there are some subtle "namespacing" issues w.r.t. providers and their prototypes that causes some things to fail pretty hard. I think the same type is getting imported under two names and the prototype chain checking is failing as a result. Whoever takes this bug will have a "fun" time sorting it out!
Comment 3•8 years ago
|
||
FHR is going away per bug 1209088, lets take a look whether this is still needed.
Whiteboard: [measurement:client]
Comment 4•6 years ago
|
||
See https://bugzilla.mozilla.org/show_bug.cgi?id=1497137; component has been deprecated.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•