1209088 - [meta] Disable & remove FHR on desktop

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect, P3)

Description

[Georg Fritzsche [:gfritzsche]]

Once we landed bug 1208376 (disabling FHR upload), we can start to investigate fully disabling FHR on desktop and let it ride the trains.

If that goes well we can later remove the FHR desktop code.

Comment 1

[Benjamin Smedberg]

Let's not move too slowly. I think we can remove the code immediately.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Removing the providers in bug 1230530 should be a rather stand-alone bug to work on.

Other work i can think of:
* removal of all of services/datareporting, services/healthreport, services/metrics
* investigating code covered by MOZ_SERVICES_HEALTHREPORT, MOZ_SERVICES_METRICS and any AppConstants.jsm equivalents:
  https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_HEALTHREPORT&redirect=false&case=true
  https://dxr.mozilla.org/mozilla-central/search?q=MOZ_SERVICES_METRICS&redirect=false&case=true
* find out if we have other build flags here
* investigate code that uses "@mozilla.org/datareporting/service;1" et al
* watch out that we don't have any JS/JSMs left in any package-manifest.in or other registrations
* remove any now-unused preferences for metrics, healthreport, datareporting

One problem is that we have to coordinate properly with the Android side (bug 1230206 and bug 1183320) for clean landings and not introducing temporary workarounds etc.

Comment 3

[Richard Newman [:rnewman]]

The Android codebase is entirely separate, and we don't ship any of the desktop code. 

We do use MOZ_SERVICES_HEALTHREPORT, but it's set in mobile/android/confvars.sh, so whatever you do to the desktop confvars shouldn't break anything. We use that to enable about:healthreport, and AIUI we're keeping that around, so perhaps it'll stay set.

Comment 4

[Alessio Placitelli [:Dexter]]

Closing this, all the dependencies landed.