836418 - Many instances of "warning: 'PRLogModuleInfo* getLogModule()' defined but not used" in WebRTC code, in opt builds

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

In this Linux opt build log
 https://tbpl.mozilla.org/php/getParsedLog.php?id=19264911&tree=Try
we have 24 lines warning about getLogModule() defined but not used:
{
../../../../../media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp:19:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
../../../../../media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:46:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
../../../../../media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp:19:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
../../../../../media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:46:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
dtlsidentity.cpp:19:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
nricectx.cpp:88:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
nricemediastream.cpp:73:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayer.cpp:17:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerice.cpp:85:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerloopback.cpp:28:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerdtls.cpp:31:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerlog.cpp:15:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerprsock.cpp:26:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
dtlsidentity.cpp:19:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
nricectx.cpp:88:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
nricemediastream.cpp:73:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerice.cpp:85:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayer.cpp:17:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerdtls.cpp:31:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerprsock.cpp:26:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerlog.cpp:15:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
transportlayerloopback.cpp:28:25: warning: 'PRLogModuleInfo* mozilla::getLogModule()' defined but not used
../../../../../media/webrtc/signaling/test/mediapipeline_unittest.cpp:39:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
../../../../media/mtransport/test/transport_unittests.cpp:41:25: warning: 'PRLogModuleInfo* getLogModule()' defined but not used
}

This is from MOZ_MTLOG_MODULE declaring that static method, in a build where the method is never called because PR_LOG is a no-op.

I think we can solve this by simply making defining MOZ_MTLOG_MODULE to do nothing in builds with PR_LOGGING disabled.

Comment 1

[Daniel Holbert [:dholbert]]

As shown here...
 https://mxr.mozilla.org/mozilla-central/source/nsprpub/pr/include/prlog.h?mark=163-186#162
...PR_LOGGING is defined iff PR_LOG is defined to something useful.  So it's the right thing to check here.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9b0f2dc2629

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9b0f2dc2629