Closed Bug 836547 Opened 9 years ago Closed 8 years ago

Remove obsolete AITC integration in Webapps.jsm

Categories

(Core Graveyard :: DOM: Apps, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: rnewman, Assigned: marco)

References

Details

Attachments

(2 files)

Follow-on from Bug 836395.

Fabrice, please move to the correct component if I messed that up!
Component: Web Apps → DOM: Apps
Product: Firefox → Core
QA Contact: jsmith
Assignee: nobody → fabrice
Marco, can you do that before we land bug 909573?
Assignee: fabrice → mcastelluccio
Attachment #796233 - Flags: review?(fabrice)
Attached patch remove_aitcSplinter Review
Do we want also to completely remove the code under sync/ ?
(In reply to Marco Castelluccio [:marco] from comment #3)
> Created attachment 796235 [details] [diff] [review]
> remove_aitc
> 
> Do we want also to completely remove the code under sync/ ?

Yes, it's obsolete and doesn't support half of what we need.
Attachment #796235 - Flags: review?(fabrice)
Comment on attachment 796235 [details] [diff] [review]
remove_aitc

Review of attachment 796235 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: this is not aitc, but an apps sync engine.
Attachment #796235 - Flags: review?(fabrice) → review+
Comment on attachment 796233 [details] [diff] [review]
remove_aitc_webappsjsm

Review of attachment 796233 [details] [diff] [review]:
-----------------------------------------------------------------

Less code is good news!
Attachment #796233 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/integration/fx-team/rev/38dde25713db
https://hg.mozilla.org/integration/fx-team/rev/1cc435abcc52

I used the Try push to figure out what commit message the second patch should have since both attached patches were the same.
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/38dde25713db
https://hg.mozilla.org/mozilla-central/rev/1cc435abcc52
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.