Closed
Bug 836766
Opened 11 years ago
Closed 11 years ago
Drop arbitrary restriction that chat windows opened by the worker are minimized
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(firefox23 fixed, firefox24 fixed)
RESOLVED
FIXED
Firefox 24
People
(Reporter: markh, Assigned: mixedpuppy)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
7.41 KB,
patch
|
markh
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
There is no reasonable requirement for chat windows opened by the worker to be opened minimized. It does nothing to prevent abuse by the provider and just adds an extra step for the user when they want to see the content of the incoming chat message. So we should just drop this arbitrary restriction. Later we could consider an optional way for a chat window to be opened minimized (whether by the worker of via the navigator api), but there doesn't seem to be a current use-case for this - so we should only do this when such a use-case can be identified.
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=08842555faab
Assignee: nobody → mixedpuppy
Attachment #756856 -
Flags: review?(mhammond)
Reporter | ||
Updated•11 years ago
|
Attachment #756856 -
Flags: review?(mhammond) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d1434e45bd9
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d1434e45bd9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 756856 [details] [diff] [review] remove forced minimize mode [Approval Request Comment] Bug caused by (feature/regressing bug #): 784535 User impact if declined: incoming call/chat requests are minimized making them largely unnoticeable by users. this is especially problematic for incoming webrtc calls in talkilla Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #756856 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #756856 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 5•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/6d5e8bc3b065
status-firefox23:
--- → fixed
status-firefox24:
--- → fixed
Deprioritizing for verification since it looks like this has in-testsuite test coverage. Please drop the [qa-] tag and add the verifyme keyword if QA verification is desired.
Flags: in-testsuite+
Whiteboard: [qa-]
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•