Closed
Bug 836876
Opened 11 years ago
Closed 7 years ago
Add ISC-licensed "inet_ntop" summary to about:license
Categories
(mozilla.org :: Licensing, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: abr, Assigned: jesup)
References
Details
Attachments
(1 file)
2.88 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
As part of bug 825927, we are importing third-party code for formatting of IP addresses into strings. The original code is available from just about any BSD operating system repository, such as: http://ftp.netbsd.org/pub/NetBSD/NetBSD-release-6/src/lib/libc/inet/inet_ntop.c We need text added to about:license, under nrappkit (about:license#nrappkit). At the end of the existing text, we should append: The following license applies to sections of the file: media/mtransport/third_party/nrappkit/src/util/util.c Copyright (c) 2004 by Internet Systems Consortium, Inc. ("ISC") Copyright (c) 1996-1999 by Internet Software Consortium. Permission to use, copy, modify, and distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies. THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL ISC BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 709031 [details] [diff] [review] license for inet_ntop() Turns out the license was already there, just applying to a different file. Given that, I'm going to land the code under the presumption adding another file to the list a license applies to is formality. Patch for license.html attached.
Attachment #709031 -
Flags: review?(gerv)
Comment 3•11 years ago
|
||
Comment on attachment 709031 [details] [diff] [review] license for inet_ntop() r=gerv. Gerv
Attachment #709031 -
Flags: review?(gerv) → review+
Comment 4•11 years ago
|
||
Comment on attachment 709031 [details] [diff] [review] license for inet_ntop() Review of attachment 709031 [details] [diff] [review]: ----------------------------------------------------------------- Noticed a problem... ::: toolkit/content/license.html @@ +98,5 @@ > <li><a href="about:license#nicer">nICEr License</a></li> > <li><a href="about:license#nrappkit">nrappkit License</a></li> > <li><a href="about:license#openvision">OpenVision License</a></li> > <li><a href="about:license#praton">praton License</a></li> > + <li><a href="about:license#praton1">praton and inet_ntop License</a></li> this uses #praton1 @@ +2569,5 @@ > + > + > + <hr> > + > + <h1><a id="praton2"></a>praton and inet_ntop License</h1> this uses #praton2
Comment 5•11 years ago
|
||
Good spot! Gerv
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/16d7e68a06c7 license for inet_ntop() r=gerv
Assignee | ||
Comment 8•7 years ago
|
||
Wasn't on my needinfo list; somehow this got missed. Was primarily a formality since we already had the license in the tree, per comment 2, so I don't think we need to uplift it.
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/16d7e68a06c7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•