837012 - [layers-refactoring] Rendering Thebes layers is buggy as hell

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

Linux, GL, OMTC, non-tiled Thebes layers are rendering pretty wonky. I suspect buffer rotation is the culprit.

Comment 1

[Nicolas Silva [:nical]]

I think this bug is a duplicate of bug 825950.
It works well if xrender is disabled, so it probably means that we do some manual gl->fBindTexture when we should use foo->BindTexture() because texture from pixmap needs to do some extra work when binding the texture.

Comment 2

[Nick Cameron [:nrc]]

Hmm, doesn't seem to be a gl->fBindTexture call, I don't see any calls to fBindTexture that don't go through the TextureImageGLX::BindTexture.

Comment 3

[Nick Cameron [:nrc]]

Probably not buffer rotation either because that has been disabled (without a TODO tag, :-( ) anyway.

Comment 4

[Nick Cameron [:nrc]]

Buffer rotation is broken as well, btw, we should probably fix that...

Comment 5

[Nick Cameron [:nrc]]

Yeah! Fixed it. CompositorOGL was just ignoring some of the parameters to DrawQuad. Looks like it works now, but probably needs some testing.