837274 - Clear Private Data: long delay before "Private data cleared" notification

Status: VERIFIED DUPLICATE of bug 913806

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

On my Galaxy S, Clear Private Data usually takes about 20 seconds to show the "Private data cleared" notification. 

I noticed this while reviewing a new Robocop test (bug 745041), but it can be reproduced manually also. 

STR:

Open "Settings"
Select "Clear private data"
(Keep all defaults: all items selected)
Select "Clear data" button
Wait for "Private data cleared" 

The 20 s delay is present even with a clean profile (fresh uninstall/install).

I do not see this delay on other devices. On the Galaxy Tab, the delay is less than 2 s.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

The Galaxy S has a horribly slow file system. They added journaling to FAT

http://www.google.com/patents/US7970804
http://seanmonstar.com/post/3044912970/galaxy-s-file-system

Comment 2

[Catalin Suciu [:csuciu]]

I'm seeing long delays on displaying the "Private data cleared" notification on HTC Desire (Android 2.2) too.
Also I saw the "ClearPrivateData" test failing often on try server because the "Private data cleared" notification was not triggered in time

Comment 3

[Doug Turner (:dougt)]

This is terrible bad. :(

I saw this on a galaxy tablet 10"

Comment 4

[:Gavin Sharp [email: [e-mail]]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Sanitizer.jsm is a fork of http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js.

The main issue is usually clearing the disk cache (bug 648232). Maybe dougt can help get that bug fixed!

Comment 5

[Doug Turner (:dougt)]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Sanitizer.jsm#62


Honza,  this is going to be fast w/ the rewrite, right?

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Doug Turner (:dougt) from comment #5)
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/
> Sanitizer.jsm#62
> 
> 
> Honza,  this is going to be fast w/ the rewrite, right?

Yes, completely async and non-blocking.

Comment 7

[Doug Turner (:dougt)]

damn, i like the sound of that.

Comment 8

[Doug Turner (:dougt)]

sounds like this will just work after we land Gum.

Comment 9

[Jason Duell]

So the issue with the current cache is that we evict all the entries instead of doing nsDeleteDir, according to :michal because we can't do nsDeleteDir when we have any cache entries open:
  
  https://bugzilla.mozilla.org/show_bug.cgi?id=648232#c33

We should make sure that this isn't an issue in the new cache API.  Assigning to Honza to make sure that happens, and marking this as depending on cache rewrite (bug 877301).  So this won't get fixed until the new cache lands, but it shouldn't need any work after that (beyond verifying that things are faster--don't skip that step! :)

Comment 11

[Catalin Suciu [:csuciu]]

I've tested on several devices including a Galaxy S with Android 2.2 and the issue seems to be fixed after landing the changes from bug 913806.