Closed
Bug 837436
Opened 13 years ago
Closed 13 years ago
Work - Use the default notificationbox widget from toolkit
Categories
(Firefox for Metro Graveyard :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: feature=work)
Attachments
(1 file)
|
13.67 KB,
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
I split this out of my work from bug 836969.
Metro Firefox currently has a custom <notificationbox> binding that adds an extra <stack>. This was useful on phones where the space was constrained, but not so much on desktop. Reasons to get rid of it:
1) Extra code we don't need.
2) Doesn't work well without hard-coded height/width (so it blocks bug 836969).
3) Uses custom styles designed for our Android theme, not very Metro-y.
Attachment #709415 -
Flags: review?(fyan)
|
Assignee | |
Updated•13 years ago
|
No longer blocks: 831949
Summary: Use the default notificationbox widget from toolkit → Work - Use the default notificationbox widget from toolkit
Whiteboard: [feature=work][has patch]
|
||
Comment 1•13 years ago
|
||
Comment on attachment 709415 [details] [diff] [review]
patch
Review of attachment 709415 [details] [diff] [review]:
-----------------------------------------------------------------
Code looks fine. I haven't tested it though (was admittedly too lazy to apply its dependencies to my patch queue), so I hope you did! ;)
Attachment #709415 -
Flags: review?(fyan) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [feature=work][has patch] → feature=work
|
||
Updated•11 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•