837477 - Cannot lower volume of camera shutter sound

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Andrew Overholt [:overholt]]

The camera shutter sound (see [1] before you say that this is the law :) ) still plays very loudly when the volume that I can change with the hardware buttons while on the home screen (Jonas says it's the ringer volume only) is at zero.  My Android phone mutes its camera shutter sound when I have the phone volume at zero.

Unagi
2013-01-31 nightly build

[1]
http://android.stackexchange.com/questions/32442/jurisdictions-where-camera-shutter-sound-is-mandated-by-law

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Is it adjustable or only could be muted? My android phone's camera is not mutable nor adjustable.

Comment 2

[Andrew Overholt [:overholt]]

(In reply to Alive Kuo [:alive] from comment #1)
> Is it adjustable or only could be muted? My android phone's camera is not
> mutable nor adjustable.

My android phone allows its camera "shutter" volume to be adjusted *and* muted.  I have a Galaxy Nexus running Jelly Bean.

Comment 3

[Andrea Marchesini [:baku]]

Currently the shutter is set to use 'public notification' audio channel.
Probably we should just change it to 'notification'.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 709683 [details] [diff] [review]
patch

Review of attachment 709683 [details] [diff] [review]:
-----------------------------------------------------------------

I believe you forget the permission in manifest.
Also, system app has a copy of camera app in run time.

Is it to say we abandon the publicnotification channel forever?

Comment 6

[Marco Chen [:mchen]]

Is it possible that we link publicnotification volume with notification one (In Gaia)?
And we add a new pref to control whether this link is existing or not.
So for partner's point of view, they can decide this behavior by themselves.

1. Link public with notification?
2. public can't be muted?

Comment 7

[Dale Harvey (:daleharvey)]

> Also, system app has a copy of camera app in run time.

I dont know if thats what you mean but just a heads up that doesnt mean there needs to be any changes in the homescreen apart from permissions, the app is copied at build time

Comment 8

[Andrea Marchesini [:baku]]

Where else do we use public notifications?

Comment 9

[Andrea Marchesini [:baku]]

Attachment: patch b

Comment 10

[Andrew Overholt [:overholt]]

I realized you can turn this sound off entirely in the settings so I'm less concerned about this :)

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 710097 [details] [diff] [review]
patch b

Review of attachment 710097 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine with me. Does it affect if we play the audio through headphones and/or speaker? I.e. do we have different policies for "publicnotification" vs. "notification"?

If so an option would be to make "publicnotification" and "notifiaction" use the same volume setting.

Comment 12

[Marco Chen [:mchen]]

The notification & publicnotification will all go through speaker & headset. But in Android audio policy there is a property called ro.camera.sound.forced, this is used to decode whether shutter sound can be muted or not. So I suggest to keep shutter sound on publicnotification channel. And just link with notification's volume.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 710097 [details] [diff] [review]
patch b

Review of attachment 710097 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you also remove public-notification channel permission in system app.
It's just for the clone of camera app to be a secure camera when phone lock is on.

Comment 14

[Andrea Marchesini [:baku]]

https://github.com/mozilla-b2g/gaia/pull/8021

Comment 15

[Dale Harvey (:daleharvey)]

Merged in: https://github.com/mozilla-b2g/gaia/commit/e06e9244dc7acc03cf4c08c1c49496eed789eb91

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit e06e9244dc7acc03cf4c08c1c49496eed789eb91 as:
v1-train: abfede404bb3c717f33d9c609464f8cf52504edf

Comment 17

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Was this fix only concerned with setting the correct audio channel type (i.e. from 'publicnotification' to 'notification')?

The 'notification' audio channel doesn't seem to be muted when volume is set to 0 (either from hardware buttons or Settings > Sounds > Ringer & Notifications slider) on latest master (00fdfe0), thus the shutter sound is played loudly regardless of the volume level.

Comment 18

[Julien Wajsberg [:julienw]]

:mihai, could this be also related to Bug 863294 ?

Comment 19

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Julien Wajsberg [:julienw] from comment #18)
> :mihai, could this be also related to Bug 863294 ?

Julien, thanks for pointing this out, it is indeed related. I think the volume for all sounds that are played through the 'notification' channel is not properly handled, and most probably the fix for bug 819842 will solve this.

Comment 20

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Mihai Cirlanaru [:mcirlanaru] from comment #17)
> Was this fix only concerned with setting the correct audio channel type
> (i.e. from 'publicnotification' to 'notification')?
> 
> The 'notification' audio channel doesn't seem to be muted when volume is set
> to 0 (either from hardware buttons or Settings > Sounds > Ringer &
> Notifications slider) on latest master (00fdfe0), thus the shutter sound is
> played loudly regardless of the volume level.

That sounds really strange with this patch! After moving to notification channel it should be muted as well as you make the volume down to 0.