Closed
Bug 837493
Opened 11 years ago
Closed 11 years ago
Add private browsing page
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.18
People
(Reporter: neil, Assigned: neil)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
10.88 KB,
patch
|
iannbugzilla
:
review+
philip.chee
:
review+
|
Details | Diff | Splinter Review |
We need a page to give people something to look at when they open a new private browsing window. Eventually we'll have a page with some nice stuff on it.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #709475 -
Flags: review?(philip.chee)
Attachment #709475 -
Flags: review?(iann_bugzilla)
Comment on attachment 709475 [details] [diff] [review] Proposed patch I think we need to at least give different content depending on whether the page has been opened through New Private Window or not.
Attachment #709475 -
Flags: review?(iann_bugzilla) → feedback+
Assignee | ||
Comment 3•11 years ago
|
||
![]() |
||
Comment 4•11 years ago
|
||
Comment on attachment 709475 [details] [diff] [review] Proposed patch Rather basic, but I assume that you will be adding content in followup bugs?
Attachment #709475 -
Flags: review?(philip.chee) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #709475 -
Attachment is obsolete: true
Attachment #714928 -
Flags: review?(philip.chee)
Attachment #714928 -
Flags: review?(iann_bugzilla)
Assignee | ||
Updated•11 years ago
|
Attachment #709971 -
Attachment is obsolete: true
Comment on attachment 714928 [details] [diff] [review] Improved patch >+ <button label="&privatebrowsingpage.learnmore.label;" >+ accesskey="&privatebrowsingpage.learnmore.accesskey;" >+ disabled="true" >+ onclick="openHelp('private-browsing', 'chrome://communicator/locale/help/suitehelp.rdf');"/> So even though this is disabled, clicking on it still works! >+++ b/suite/locales/en-US/chrome/common/aboutPrivateBrowsing.dtd >+<!ENTITY privatebrowsingpage.moreinfo "While this computer won't have a record of your browsing history, your employer or Internet service provider might still be able to track the pages you visit."> Shouldn't that be "Internet Service Provider"? >+<!ENTITY privatebrowsingpage.info "To start &privatebrowsingpage.title;, you can also select File â New â Private Window."> Not sure what the character between File, New and Private Window should be, shows as a long "-" for me. r=me with those fixed.
Attachment #714928 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Ian Neal from comment #6) > (From update of attachment 714928 [details] [diff] [review]) > >+ <button label="&privatebrowsingpage.learnmore.label;" > >+ accesskey="&privatebrowsingpage.learnmore.accesskey;" > >+ disabled="true" > >+ onclick="openHelp('private-browsing', 'chrome://communicator/locale/help/suitehelp.rdf');"/> > So even though this is disabled, clicking on it still works! My bad, all those onclick= should be oncommand= of course. D'oh! > >+<!ENTITY privatebrowsingpage.moreinfo "While this computer won't have a record of your browsing history, your employer or Internet service provider might still be able to track the pages you visit."> > Shouldn't that be "Internet Service Provider"? I capitalised the I because it's the Internet (as opposed to any other internet that may exist; a bit like the way the Moon is special to us, but other planets have their own moons). Although ISP stands for Internet service provider, I don't think you need to capitalise them. > >+<!ENTITY privatebrowsingpage.info "To start &privatebrowsingpage.title;, you can also select File â New â Private Window."> > Not sure what the character between File, New and Private Window should be, > shows as a long "-" for me. Yes, it should be an em dash. (I wanted to be posh and not just use a minus sign.) Those funny characters are what you see if you open it in an editor that's expecting ISO-8859-1 instead of UTF-8.
Couple of other things through testing: 1/ The access key (no modifiers) for the buttons in the about page, only seem to work when the button is focused - is that expected? 2/ Pressing the access key when the button has focus also causes the quick link toolbar to appear.
Assignee | ||
Comment 9•11 years ago
|
||
(In reply to Ian Neal from comment #8) > Couple of other things through testing: > 1/ The access key (no modifiers) for the buttons in the about page, only > seem to work when the button is focused - is that expected? With default preferences you need to press Shift to activate in-content access keys. > 2/ Pressing the access key when the button has focus also causes the quick > link toolbar to appear. You mean fast find? I think we have a bug on disabling fast find on about: pages.
![]() |
||
Comment 10•11 years ago
|
||
Comment on attachment 714928 [details] [diff] [review] Improved patch r=me. Some suggestions for improvement which could be done in a follow-up bug: > + <vbox id="normal" align="start"> > + <description>&privatebrowsingpage.normal;</description> I prefer the way Firefox organises their page. With "You are not currently in a private window" or "Nightly won't remember any history for this window." just under the mail title block. Needs more CSS. Suggestions: # Like our about:certerror and about:blocked we should have a background image in the top left of the container. Firefox uses chrome://global/skin/icons/question-48.png # Set a favicon for this page so that it shows up in the tab and locationbar. # The contents looked rather cramped vertically. Needs more vertical space around both buttons. > +<!ENTITY privatebrowsingpage.info "To start &privatebrowsingpage.title;, you can also select File ― New ― Private Window."> ... > Not sure what the character between File, New and Private Window should be, > shows as a long "-" for me. I think we should use some sort of right arrow or caret. I'm sure there is a UTF-8 code point for something like this. In Firefox the title bar shows "Would you like to start Private Browsing? - Nightly" when in normal mode. Ours just says "private:browsing"
Attachment #714928 -
Flags: review?(philip.chee) → review+
![]() |
||
Comment 11•11 years ago
|
||
>> Not sure what the character between File, New and Private Window should be, shows as
>> a long "-" for me.
> Yes, it should be an em dash. (I wanted to be posh and not just use a minus sign.)
I think since we areusing UTF-8 we could use some sort of right arros or caret.
Assignee | ||
Comment 12•11 years ago
|
||
Well Firefox just uses a > sign which seems wrong to me.
Assignee | ||
Comment 13•11 years ago
|
||
Pushed comm-central changeset d1fca17b4323.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Summary: Add basic private browsing page → Add private browsing page
![]() |
||
Comment 14•11 years ago
|
||
> Well Firefox just uses a > sign which seems wrong to me. Pick something from here ;) http://www.fileformat.info/info/unicode/block/arrows/utf8test.htm
Assignee | ||
Comment 15•11 years ago
|
||
Only one of those arrows works in Windows XP for me, it's the same one that Bugzilla inline history uses and looks like File → New → Private Window. Even in a decent font it doesn't look as good as an em dash IMHO.
Updated•11 years ago
|
Target Milestone: --- → seamonkey2.18
Comment 16•11 years ago
|
||
I think there is a typo in privatebrowsingpage.description , " cookies or browser, search download or web form history." Did you mean "cookies or browser history"?
Assignee | ||
Comment 17•11 years ago
|
||
(In reply to Théo Chevalier from comment #16) > I think there is a typo in privatebrowsingpage.description , " cookies or > browser, search download or web form history." Did you mean "cookies or > browser history"? You're right, there's a comma missing between search and download.
![]() |
||
Comment 18•11 years ago
|
||
> You're right, there's a comma missing between search and download. http://hg.mozilla.org/comm-central/rev/2ac76ca7fbda (Followup to fix typo r=IanN)
You need to log in
before you can comment on or make changes to this bug.
Description
•