Closed Bug 837563 Opened 8 years ago Closed 7 years ago

Enable PulseAudio cubeb backend by default

Categories

(Core :: Audio/Video, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

Using PulseAudio as the default cubeb backend for Linux is the goal.  The ALSA backend will remain supported and the appropriate backend will be selected at runtime based on the host machine's capabilities.
Depends on: 837564
Most of this was done in bug 837564.  Once that lands, all that remains is to alter the build.

The build changes needed are: alter configure.in to use PulseAudio by default (and allow --disable-pulseaudio), remove PULSEAUDIO_LIBS from the libxul link, and possibly add an --enable-pulseaudio-link (or something) that does include PULSEAUDIO_LIBS in the libxul link for any other code that uses PulseAudio (WebRTC?)
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attached patch bug837563_v0.patch (obsolete) — Splinter Review
Will see how it goes on Try before requesting review.
Attached patch bug837563_v0.patch (obsolete) — Splinter Review
Let's try that again.

https://tbpl.mozilla.org/?tree=Try&rev=785ab040249c
Attachment #822126 - Attachment is obsolete: true
Attachment #822130 - Attachment is obsolete: true
Looks good on Try.

Enable PulseAudio by default in configure, remove existing -lpulse since in-tree uses dlopen libpulse when available.
Attachment #824970 - Flags: review?(mh+mozilla)
Comment on attachment 824970 [details] [diff] [review]
bug837563_v1.patch

Review of attachment 824970 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5563,5 @@
> +
> +MOZ_ARG_DISABLE_BOOL(pulseaudio,
> +[  --disable-pulseaudio          Disable PulseAudio support],
> +   MOZ_PULSEAUDIO=,
> +   MOZ_PULSEAUDIO=1)

What is this supposed to achieve, if you remove MOZ_PULSEAUDIO_LIBS?
Attachment #824970 - Flags: review?(mh+mozilla)
Comment on attachment 824970 [details] [diff] [review]
bug837563_v1.patch

Review of attachment 824970 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5563,5 @@
> +
> +MOZ_ARG_DISABLE_BOOL(pulseaudio,
> +[  --disable-pulseaudio          Disable PulseAudio support],
> +   MOZ_PULSEAUDIO=,
> +   MOZ_PULSEAUDIO=1)

Ah, saw comment 7.
Attachment #824970 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/6b6ea9376519
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
See Also: → 934290
Depends on: 934290
If building now requires libpulse-dev to be installed, this should be added to the documentation at
https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Linux_Prerequisites
(In reply to mjh563 from comment #12)
> If building now requires libpulse-dev to be installed, this should be added
> to the documentation

Thanks for the reminder, now done.
Depends on: 934232
In the future, it would be nice if you made the configure error message tell the user what they need to do to work around this error (--disable-pulseaudio in this case).
Depends on: 952828
> In the future, it would be nice if you made the configure error message tell the user what
> they need to do to work around this error (--disable-pulseaudio in this case).

+1

Thanks for the PulseAudio support!
Actually, given that we have a fallback with ALSA, it shouldn't be a configure error, but a warning.
Filed bug 965653 to pass metadata to PulseAudio.
Whiteboard: [qa-]
Regression: Audio permanently broken when the Pulse server restarts. Filed bug 986985.
You need to log in before you can comment on or make changes to this bug.