Closed
Bug 837597
Opened 12 years ago
Closed 12 years ago
Move HTMLMapElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
|
8.89 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
6.30 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
2.94 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #709635 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #709636 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #709637 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #709636 -
Attachment is obsolete: true
Attachment #709636 -
Flags: review?(peterv)
Attachment #709658 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 5•12 years ago
|
||
And now with some changes in the right patch.
Attachment #709637 -
Attachment is obsolete: true
Attachment #709637 -
Flags: review?(peterv)
Attachment #709659 -
Flags: review?(peterv)
|
||
Comment 6•12 years ago
|
||
Comment on attachment 709635 [details] [diff] [review]
Part a: Namespacing
r=me
Attachment #709635 -
Flags: review?(peterv) → review+
|
|
||
Comment 7•12 years ago
|
||
Comment on attachment 709658 [details] [diff] [review]
Part b: Binding
Add a comment about GetName, and r=me
Attachment #709658 -
Flags: review?(peterv) → review+
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 709659 [details] [diff] [review]
Part c: A test
r=me. Maybe we should have added these for the other things we converted...
Attachment #709659 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df5858bb2c01
https://hg.mozilla.org/mozilla-central/rev/c7282e1f1015
https://hg.mozilla.org/mozilla-central/rev/59cc512a67f2
https://hg.mozilla.org/mozilla-central/rev/f5a2b4b57086
https://hg.mozilla.org/mozilla-central/rev/2e1cc3e2bd51
https://hg.mozilla.org/mozilla-central/rev/3cea33d52017
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
Assignee | |
Comment 10•12 years ago
|
||
(In reply to :Ms2ger from comment #9)
> https://hg.mozilla.org/mozilla-central/rev/f5a2b4b57086
> https://hg.mozilla.org/mozilla-central/rev/2e1cc3e2bd51
> https://hg.mozilla.org/mozilla-central/rev/3cea33d52017
And those were for bug 837648...
You need to log in
before you can comment on or make changes to this bug.
Description
•