837670 - [Clock] "ready to use" perf measurement

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect, P2)

Description

[Julien Wajsberg [:julienw]]

We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar.

For the Clock, it should be triggered when the correct time is finally displayed.

Comment 1

[William Hsu [:whsu]]

Any update? Thanks.
Who will in charge of the task?

Comment 2

[Julien Wajsberg [:julienw]]

It should not be difficult to do but someone has to do it. We're currently busy wuth other bugs.

Comment 4

[Marcus Cavanaugh [:mcav]]

per :hub -- PerformanceTestingHelper.dispatch("startup-path-done") is usually what is being used

Comment 5

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16582

Hey Mike, could you verify that this is the correct place to put the performance marker that says "the app is ready to use"?

Comment 6

[Julien Wajsberg [:julienw]]

I think you also need to whitelist the app in /tests/performance/startup_events_test.js

Comment 7

[Hubert Figuiere [:hub]]

Also the travis failure seems to be related.

Comment 8

[Marcus Cavanaugh [:mcav]]

Good catch, Julien and Hubert, thanks! Updated the PR, Travis passes.

Comment 9

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8380922 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16582

Hey Marcus,

Looks good to me. I've recommended a change that would require some additional code--see the pull request on GitHub. If you like that idea, then I'd be happy to re-review once you've implemented it. If you think it's out-of-scope for this bug, then file a separate bug for me to complete. Or, if you disagree, let me know why :)

Comment 10

[Marcus Cavanaugh [:mcav]]

Landed, with all fixes as suggested by Mike, Hubert, and Julien:

https://github.com/mozilla-b2g/gaia/commit/64c27638cadc7d4e3a629757a2dc54dd07f235d9