Closed Bug 837678 Opened 7 years ago Closed 6 years ago

[cost control] Implement new startup loading events

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.1 S1 (1aug)
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: julienw, Assigned: mai)

References

Details

(Keywords: perf, Whiteboard: [c=automation p= s=2014.08.01.t u=])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Eli
: review+
salva
: review+
Details | Review
We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar.

For Cost Control, it should be triggered when the user can actually manipulate the app.

We should measure 2 runs for this app:
- in the first run we'll measure when we arrive to the "configuration" page and can manipulate it.
- in the second run the configuration should be set up in advance, and we'll measure when the user can manipulate the UI
No longer depends on: gaia-perf-measure
Summary: "ready to use" perf measurement → [cost control] "ready to use" perf measurement
Depends on: 837139
Keywords: perf
Whiteboard: [c=instrumentation p=]
Priority: -- → P2
Whiteboard: [c=instrumentation p=] → [c=automation p= s= u=]
Assignee: nobody → mri
Depends on: 971438
Blocks: 996043
Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented.
Summary: [cost control] "ready to use" perf measurement → [cost control] Implement new startup loading events
As an FYI, this implementation needs to land in 2.0 as it is important for meeting release performance acceptance criteria.

https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance
Attached file patch v1.0
Hi Salva, 
would you give me your feedback?
Attachment #8440543 - Flags: feedback?(salva)
Comment on attachment 8440543 [details] [review]
patch v1.0

JM, could you help Marina with the measurement of performance? Thank you.
Attachment #8440543 - Flags: feedback?(salva) → feedback?(jmcf)
Comment on attachment 8440543 [details] [review]
patch v1.0

I put some important comments in the Pull Request. Enough to give a r-
Also you need blocker bug 971438 to be solved it be able to ever run the tests.
Comment on attachment 8440543 [details] [review]
patch v1.0

canceling my feedback request as there are substantial comments to be addressed
Attachment #8440543 - Flags: feedback?(jmcf)
Status: NEW → ASSIGNED
Any updates on having this revised and resolved?
Hi Eli,
I've update the pr and I sent you an email with the pending info,
sorry for delay
Comment on attachment 8440543 [details] [review]
patch v1.0

I've update the pr after our talking, would you mind reviewing the patch?
Regards
Attachment #8440543 - Flags: review?(eperelman)
Comment on attachment 8440543 [details] [review]
patch v1.0

If I am understanding the flow correctly, things look OK from the performance side, but I would still like to have this reviewed by an owner/peer to make sure the flow is correct.
Attachment #8440543 - Flags: review?(eperelman)
Attachment #8440543 - Flags: review?(21)
Attachment #8440543 - Flags: review+
Comment on attachment 8440543 [details] [review]
patch v1.0

Salva,
as owner of the App, do you mind reviewing the patch?
Regards
Attachment #8440543 - Flags: review?(salva)
I need some info about my comments from the performance team about:
https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102880
https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102961

The code looks well but delaying the r+ until the feedback from Eli.
Flags: needinfo?(eperelman)
Comments on GitHub.
Flags: needinfo?(eperelman)
Comment on attachment 8440543 [details] [review]
patch v1.0

Mai, move the event in [1] and that's all. Thank you very much!

[1] https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102961
Attachment #8440543 - Flags: review?(salva) → review+
Master: 4c7f92ce401fcb784a2ef8a378451eaa9a9554c3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8440543 [details] [review]
patch v1.0

Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria, comment 2.

[Feature/regressing bug #]: bug 996038
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests
[Risks and why]: Low, as there are no user-perceived changes
[String/UUID change made/needed]: n/a
Attachment #8440543 - Flags: approval-gaia-v2.0?
Whiteboard: [c=automation p= s= u=] → [c=automation p= s=2014.08.01.t u=]
Target Milestone: --- → 2.1 S1 (1aug)
Attachment #8440543 - Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
You need to log in before you can comment on or make changes to this bug.