Closed Bug 837851 Opened 13 years ago Closed 12 years ago

Add permission for editing the keywords field of an article

Categories

(support.mozilla.org :: Knowledge Base Software, task, P3)

Product:
support.mozilla.org
Component:
Knowledge Base Software
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013Q1

People

(Reporter: verdi, Assigned: rehandalal+mozilla)

Details

(Whiteboard: u=contributor c=wiki p=1 s=2013.4)

The keywords field is not something that needs to be changed for most articles. Also its use is frequently misunderstood resulting in articles getting keywords assigned that hurt rather than help the article. Please move the keywords field to the description section so that only a reviewer or higher can change them.
Keywords are a revision level field. So changing them will create a new revision that needs to go through the approval process, l10n workflow, etc. We could probably make it so that only certain users see it in the form and can change it. Moving it up to the document level (description) area would require us to make schema changes, migrate data and who knows what else.
Michael, can you clarify the original purpose? Would it be okay to just show this to reviewers and higher?
Being shown to reveiwers or higher should be ok. The problem that I'm trying to fix is that this is one of 3 fields that people see when they edit and it's an attractive target for additions. Most of those additions aren't needed and/or hurt rather than help the article.
Priority: -- → P3
Whiteboard: u=contributor c=wiki p= s=2013.3
Target Milestone: --- → 2013Q1
This should be pretty simple, just add a permission and change the rendering depending on permission. 1pt.
Whiteboard: u=contributor c=wiki p= s=2013.3 → u=contributor c=wiki p=1 s=2013.3
Falling to next sprint.
Whiteboard: u=contributor c=wiki p=1 s=2013.3 → u=contributor c=wiki p=1 s=2013.4
Assignee: nobody → rdalal
Deployed to prod now. I gave the permission to the Administrators group for now.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Move the keywords field to the description section of the article → Add permission for editing the keywords field of an article
Can we give the permission to the reviewers group please? Admins can't maintain keywords for all articles in all languages.
(In reply to Verdi [:verdi] from comment #8) > Can we give the permission to the reviewers group please? Admins can't > maintain keywords for all articles in all languages. Done, I just assigned the permission to "Knowledge Base Reviewers" group
I can no longer change the keyword field of French articles. See https://support.mozilla.org/fr/kb/telecharger-installer-applications-firefox-os/history
(In reply to Scoobidiver from comment #10) > I can no longer change the keyword field of French articles. See > https://support.mozilla.org/fr/kb/telecharger-installer-applications-firefox- > os/history Are you in the KB Reviewers group?
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #11) > Are you in the KB Reviewers group? I was (I can still review English KB articles though so it's inconsistent with https://support.mozilla.org/groups/knowledge-base-reviewers), but my issue is with the French KB although I am a reviewer of the French KB.
(In reply to Scoobidiver from comment #12) > (In reply to Ricky Rosario [:rrosario, :r1cky] from comment #11) > > Are you in the KB Reviewers group? > I was (I can still review English KB articles though so it's inconsistent > with https://support.mozilla.org/groups/knowledge-base-reviewers), but my > issue is with the French KB although I am a reviewer of the French KB. You should be in the https://support.mozilla.org/en-US/groups/knowledge-base-reviewers group then. Ping verdi?
I'll gladly put Scoobidiver in the English KB reviewers group but that doesn't solve the problem. We need all reviewers to be able to edit keywords because, for example, they are probably different in French.
(In reply to Verdi [:verdi] from comment #14) > I'll gladly put Scoobidiver in the English KB reviewers group but that > doesn't solve the problem. We need all reviewers to be able to edit keywords > because, for example, they are probably different in French. Well, the KB reviewers group has the permission. If other groups need the permission as well, we can fix that in the admin.
Ricky, how does this work with the automated locale groups feature? locale leaders and reviewers in locales should always get this permission.
Right now we aren't use the locale groups for any permission yet. If they need this then we'll have to specify it when we implement that.
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #17) > Right now we aren't use the locale groups for any permission yet. If they > need this then we'll have to specify it when we implement that. If it's not implemented soon, this bug should be backed out as translations by new contributors (don't know the keyword stuff) can't be reviewed. That prevents from recruiting new contributors. See for instance https://support.mozilla.org/fr/localization/unreviewed
(In reply to Scoobidiver from comment #18) > If it's not implemented soon, this bug should be backed out as translations > by new contributors (don't know the keyword stuff) can't be reviewed. That > prevents from recruiting new contributors. See for instance > https://support.mozilla.org/fr/localization/unreviewed Sorry, I fail to understand the issue here. This permission has nothing to do with reviewing articles. It's only about being able to edit the keywords. Reviews should happen as usual. If you are somebody is missing the permission, then we should give it to you.
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #19) > Sorry, I fail to understand the issue here. This permission has nothing to > do with reviewing articles. I have the permission to review articles but if I review them: 1. how do I know that keywords of those articles need to be removed? 2. how do contributors know they chose wrong keywords so that they won't make the same mistake in the future?
It is possible that this permission *should* only be applied to en-US documents. In fact, I think that makes most sense.
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #21) > It is possible that this permission *should* only be applied to en-US > documents. In fact, I think that makes most sense. +1. Locales are less polluted with revisions that only change (incorrectly) keywords. I let you file a dedicated bug.
Scoobi, that would mean that localizers wouldn't be able to add any keywords. You are okay with that?
(In reply to Kadir Topal [:atopal] from comment #23) > Scoobi, that would mean that localizers wouldn't be able to add any > keywords. It has been the current state since March 7. Bug 860225 means that for non en-US articles anybody can change the keyword field.
You need to log in before you can comment on or make changes to this bug.