837870 - mozbase README.md -> m-c, remove m-c README

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Jeff Hammel]

mozilla-central has a README file:
http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/README
. In this mozbase repo, this is now README.md :
https://github.com/mozilla/mozbase/blob/master/README.md .

The modern README.md should be mirrored to mozilla-central
testing/mozbase/ and README removed from there.

Comment 1

[Jeff Hammel]

Attachment: do this thing

Comment 2

[William Lachance (:wlach)]

Comment on attachment 709910 [details] [diff] [review]
do this thing

I don't think this is the patch you intended to apply?

Comment 3

[Jeff Hammel]

Beh, indeed. Wrong bug, should be bug 837872.  Sorry about that.

Comment 4

[Jeff Hammel]

https://wiki.mozilla.org/Auto-tools/Projects/Mozbase#Mirroring_Non-packaged_Resources should be updated wrt the readme after this is done:

" README : brief overview of the role of mozbase and associated links"

Comment 5

[Jeff Hammel]

Attachment: this time for sure

Comment 6

[William Lachance (:wlach)]

Comment on attachment 710078 [details] [diff] [review]
this time for sure

lgtm

Comment 7

[Jeff Hammel]

pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fc9c8f622c5

Comment 8

[(no longer active)]

Broke the build and got backed out as a result: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2ce4d44206

Comment 9

[Jeff Hammel]

Such a lot of churn on such a silly bug :/ This fails because we brilliantly put this in the Makefile: https://hg.mozilla.org/mozilla-central/file/1eab3e0d7f53/testing/mozbase/Makefile.in#l34 .  I don't know if we should do this anymore (i'd rather go with standard practice vs deciding).

Comment 10

[Jonathan Griffin (:jgriffin)]

We don't *usually* do this. 

README files in the tree:  http://mxr.mozilla.org/mozilla-central/find?string=README

README files referenced in Makefile.in:  http://mxr.mozilla.org/mozilla-central/search?string=README&find=Makefile.in&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

I don't really see the need to put this in the Makefile.

Comment 11

[Jeff Hammel]

Thanks, :jgriffin !

+1; I'll remove this from the Makefile with this patch.  Originally, when we installed/used mozbase much differently in the tree, the intention was (IIRC) to propagate the file to the objdir where the software was then installed with python setup.py develop. Whether in that case it was important to propagate the README or not, we no longer do this and I don't feel this is necessary

Comment 12

[Jeff Hammel]

Hmmm...come to think of it....do we need setup_development.py there?

Comment 13

[Jeff Hammel]

(In reply to Jeff Hammel [:jhammel] from comment #12)
> Hmmm...come to think of it....do we need setup_development.py there?

Probably not, but I'll save that for another time.  For such a short makefile, there are several things that are probably deprecated.

Comment 14

[Jeff Hammel]

Attachment: also fix up Makefile.in

carrying r=wlach forward

Comment 15

[Jeff Hammel]

pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/da98d9067e70

This time I tested locally.  Hopefully that suffices

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/da98d9067e70