838035 - [Music][User Story] Music search auto-hints

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

Description

[Peter Dolanjski [:pdol]]

UCID: Music-020

User Story:
As a user, I want to see my search to be auto-hinted as I type, so I don't have to type more than I have to when looking for a song.

Comment 1

[Rob MacDonald [:robmac]]

Proposed flows... https://bugzilla.mozilla.org/attachment.cgi?id=710548

Comment 2

[Rob MacDonald [:robmac]]

UI specs updated and moved to dropbox:

https://www.dropbox.com/s/yepxm9hogne8apy/music-search.pdf

New version includes revisions to search field layout, transitions and additional information on what happens when the user taps on a search result.

Comment 3

[Dylan Oliver [:doliver]]

Clearing tracking-b2g18 flag from User Story bugs. This flag is for bugs that we would take fixes for in the 1.x branch. Feature work should be officially slotted into a release instead with leo+. If this story is intended for v1.1, please nominate for leo? blocking.

Comment 4

[Hubert Figuiere [:hub]]

(In reply to Rob MacDonald [:robmac] from comment #2)
> UI specs updated and moved to dropbox:
> 
> https://www.dropbox.com/s/yepxm9hogne8apy/music-search.pdf
> 
> New version includes revisions to search field layout, transitions and
> additional information on what happens when the user taps on a search result.

This document is missing (404). Where do we find the right one?

Thank you kindly.

Comment 5

[Rob MacDonald [:robmac]]

Hi Hubert - I found that spec on my Mac but it's very out of date. Flagging Jacqueline (the current Music UX owner) as an fyi but is there something specific you're wondering about? - Rob

Comment 6

[Hubert Figuiere [:hub]]

Comment 1 has a link to a PDF, if that is still valid, I'll use that, it is sufficient.

Thanks

Comment 7

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Proposed fix. With tests. Will need a rebase when dependencies land

Comment 8

[Hubert Figuiere [:hub]]

Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Include patch for bug 1079349

Comment 9

[Jim Porter (:squib)]

Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

I'm going to hold off on reviewing this until bug 1055043 lands and this is rebased. That bug is blocking all our future work on music, and I want Dominic to be able to land it ASAP.

Once bug 1055043 has landed and you've rebased this, please r? me again.

Comment 10

[Hubert Figuiere [:hub]]

I have rebased now. Will wait for landing to request review again.

Comment 11

[Hubert Figuiere [:hub]]

Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Ok, this has been all rebased after the refactor landing.

Thank you kindly.

Comment 12

[Jim Porter (:squib)]

Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

This looks good, aside from a couple of minor nits I posted about on GitHub. You may also want to get UI review before landing this.

Comment 13

[Hubert Figuiere [:hub]]

Will address the nits. Thanks.

Comment 14

[Hubert Figuiere [:hub]]

commits
https://github.com/hfiguiere/mozilla-b2g/commit/84c2cfffc1873cf8c283d408b0737baacc07e4ab
https://github.com/hfiguiere/mozilla-b2g/commit/9f858edfbfd13b054d8830b302b790368ce08abe

merged https://github.com/mozilla-b2g/gaia/commit/1331445e34db875e07b24c81c21a8576f54eb4ef

Comment 15

[Hubert Figuiere [:hub]]

I meant for the commits
https://github.com/mozilla-b2g/gaia/commit/84c2cfffc1873cf8c283d408b0737baacc07e4ab
https://github.com/mozilla-b2g/gaia/commit/9f858edfbfd13b054d8830b302b790368ce08abe

Comment 16

[Hubert Figuiere [:hub]]

Release Note Request (optional, but appreciated)
[Why is this notable]: UI change
[Suggested wording]: The search in the Music is now contextual depending on what's displayed.
[Links (documentation, blog post, etc)]:

Comment 17

[Jim Porter (:squib)]

Hub: I think we're generally supposed to squash all our commits into one before merging to make it easier for sheriffs to back things out if something broke. I don't think it's a huge deal here, but just for future reference.

Comment 18

[Hubert Figuiere [:hub]]

Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Jacqueline,

I got asked to put you as UI review. This UI change is currently in master (should appear in tomorrow nightly for 2.2). Not sure exactly what are the steps for UI review and if I got it backwards.

Thank you kindly.