Closed Bug 838035 Opened 7 years ago Closed 6 years ago

[Music][User Story] Music search auto-hints

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.2+, b2g-v2.2 fixed, relnote-b2g ?)

RESOLVED FIXED
2.1 S9 (21Nov)
feature-b2g 2.2+
Tracking Status
b2g-v2.2 --- fixed
relnote-b2g --- ?

People

(Reporter: pdol, Assigned: hub)

References

Details

(Keywords: feature)

Attachments

(1 file)

UCID: Music-020

User Story:
As a user, I want to see my search to be auto-hinted as I type, so I don't have to type more than I have to when looking for a song.
Keywords: feature
Summary: [B2G][Music][User Story] Music search auto-hints → [Music][User Story] Music search auto-hints
Whiteboard: u=user c=music s=v1.1-sprint-1
Whiteboard: u=user c=music s=v1.1-sprint-1 → u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=0
Whiteboard: u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=0 → u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=.5
Whiteboard: u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=.5 → u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=0
UI specs updated and moved to dropbox:

https://www.dropbox.com/s/yepxm9hogne8apy/music-search.pdf

New version includes revisions to search field layout, transitions and additional information on what happens when the user taps on a search result.
Whiteboard: u=rmacdonald@mozilla.com c=music s=v1.1-sprint-1 p=0
Depends on: 844235
Clearing tracking-b2g18 flag from User Story bugs. This flag is for bugs that we would take fixes for in the 1.x branch. Feature work should be officially slotted into a release instead with leo+. If this story is intended for v1.1, please nominate for leo? blocking.
tracking-b2g18: + → ---
(In reply to Rob MacDonald [:robmac] from comment #2)
> UI specs updated and moved to dropbox:
> 
> https://www.dropbox.com/s/yepxm9hogne8apy/music-search.pdf
> 
> New version includes revisions to search field layout, transitions and
> additional information on what happens when the user taps on a search result.

This document is missing (404). Where do we find the right one?

Thank you kindly.
Flags: needinfo?(rmacdonald)
Hi Hubert - I found that spec on my Mac but it's very out of date. Flagging Jacqueline (the current Music UX owner) as an fyi but is there something specific you're wondering about? - Rob
Flags: needinfo?(rmacdonald) → needinfo?(jsavory)
Comment 1 has a link to a PDF, if that is still valid, I'll use that, it is sufficient.

Thanks
Assignee: nobody → hub
Target Milestone: --- → 2.1 S7 (24Oct)
Blocks: 1018491
Proposed fix. With tests. Will need a rebase when dependencies land
Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Include patch for bug 1079349
Attachment #8506172 - Flags: review?(squibblyflabbetydoo)
Target Milestone: 2.1 S7 (24Oct) → 2.1 S8 (7Nov)
Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

I'm going to hold off on reviewing this until bug 1055043 lands and this is rebased. That bug is blocking all our future work on music, and I want Dominic to be able to land it ASAP.

Once bug 1055043 has landed and you've rebased this, please r? me again.
Attachment #8506172 - Flags: review?(squibblyflabbetydoo)
I have rebased now. Will wait for landing to request review again.
Depends on: 1055043
Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Ok, this has been all rebased after the refactor landing.

Thank you kindly.
Attachment #8506172 - Flags: review?(squibblyflabbetydoo)
Target Milestone: 2.1 S8 (7Nov) → 2.1 S9 (21Nov)
Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

This looks good, aside from a couple of minor nits I posted about on GitHub. You may also want to get UI review before landing this.
Attachment #8506172 - Flags: review?(squibblyflabbetydoo) → review+
Will address the nits. Thanks.
Release Note Request (optional, but appreciated)
[Why is this notable]: UI change
[Suggested wording]: The search in the Music is now contextual depending on what's displayed.
[Links (documentation, blog post, etc)]:
relnote-b2g: --- → ?
feature-b2g: --- → 2.2+
Hub: I think we're generally supposed to squash all our commits into one before merging to make it easier for sheriffs to back things out if something broke. I don't think it's a huge deal here, but just for future reference.
Comment on attachment 8506172 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25191

Jacqueline,

I got asked to put you as UI review. This UI change is currently in master (should appear in tomorrow nightly for 2.2). Not sure exactly what are the steps for UI review and if I got it backwards.

Thank you kindly.
Attachment #8506172 - Flags: ui-review?(jsavory)
See Also: → 1141705
Duplicate of this bug: 1018491
You need to log in before you can comment on or make changes to this bug.