Closed Bug 838040 Opened 13 years ago Closed 13 years ago

[Browser][User Story] Removing bookmarks from Bookmarks tab

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: pdol, Assigned: gasolin)

References

Details

(Keywords: feature, Whiteboard: visual design, interaction design)

Attachments

(1 file)

use button dataset.url to store url params
179 bytes, text/html
benfrancis
: review+
Details
UCID: Browser-045 User Story: As a user I want to be able to remove a bookmarked page from my "Bookmarks" tab so that I can remove stale bookmarks
Keywords: feature
Summary: [B2G][Browser][User Story] Removing bookmarks from Bookmarks tab → [Browser][User Story] Removing bookmarks from Bookmarks tab
This is mostly covered by the original interaction spec for the browser as this was feature was previously defined then punted. https://www.dropbox.com/sh/1moictrrtb6rwvv/4UK7Soe8Ix/Apps/Browser/R1_Bookmarks_v2.pdf Any additional interaction/visual input welcome.
Whiteboard: visual design, interaction design
Assignee: nobody → ben
Whiteboard: visual design, interaction design → visual design, interaction desin, u=user c=browser s=v1.1-sprint-1
Whiteboard: visual design, interaction desin, u=user c=browser s=v1.1-sprint-1 → visual design, interaction design, u=user c=browser s=v1.1-sprint-1
Depends on: 844306
Whiteboard: visual design, interaction design, u=user c=browser s=v1.1-sprint-1 → visual design, interaction design
Work in progress with 838041 (edit bookmark in bookmark tab), currently remove/edit are functional but need some final tweaking
Made a pull request to solve 838040/838041. https://github.com/mozilla-b2g/gaia/pull/8427
Assignee: bfrancis → gasolin
838040 works fine with latest pull request
Change to new approach to avoid the browser.param and also solved Homescreen button showing problem. fire link to home in bookmarktab issue as Bug 850999
Attachment #724819 - Flags: review?(bfrancis)
(In reply to Fred Lin [:gasolin] from comment #5) > Created attachment 724819 [details] Is this the next revision of the patch from bug 838041 or is it a different patch just geared at fixing this bug?
Flags: needinfo?(gasolin)
It's just geared at fixing this bug. Left comment in source for Bug 838041 and Bug 850999
Flags: needinfo?(gasolin)
Comment on attachment 724819 [details] use button dataset.url to store url params I've added some nits and questions in the bug
By "bug" I mean "pull request" :)
Comment on attachment 724819 [details] use button dataset.url to store url params I think this is going to need heavily refactoring when bugs 838041 and 850999 are implemented, but it fulfills the use case described in the bug so r=me.
Attachment #724819 - Flags: review?(bfrancis) → review+
merged to master-gaia https://github.com/mozilla-b2g/gaia/commit/3ec87491b12bbc079fbd251846778b7ee9277986 Thanks!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Uplifted commit 3ec87491b12bbc079fbd251846778b7ee9277986 as: v1-train: 5e3f84f11436d47e2aa0a11e029f07da60a7e551
status-b2g18: --- → fixed
We've got MozTrap test case coverage for this I believe, right?
Flags: needinfo?(nhirata.bugzilla)
Flags: in-moztrap?
Flags: needinfo?(nhirata.bugzilla)
Flags: in-moztrap?(nhirata.bugzilla)
Flags: in-moztrap?
#6564, rough draft. Will need to modify it.
Flags: in-moztrap?(nhirata.bugzilla) → in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: