804318 - In B2G browser, there's no way to remove default bookmarks (or other bookmarks that trigger redirects)

Status: VERIFIED DUPLICATE of bug 838040

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Load browser on B2G
 2. In the AwesomeScreen, touch "Bookmarks" to show that listing.
 3. From that view, try to remove any bookmarks there, e.g. the default bookmarks. I don't think there's a way.  (Long-press does nothing, no obvious "delete" buttons, etc)
 4. Visit the default bookmarks, and try to un-star them to un-bookmark them.

ACTUAL RESULTS:
 - In step 3 (AwesomeScreen view), there's no way to delete bookmarks
 - In step 4 (after visiting one of the default bookmarks), you can't delete the bookmark -- if you click the "star" bookmark icon, it offers to let you bookmark the *new* URL that you've been redirected to. (since the default bookmarks end up redirecting you elsewhere)

EXPECTED RESULTS: Should be able to delete the bookmarks, preferably in step 3 (awesomescreen)

I tried this with both of the default bookmarks -- http://vds.vivo.br.com and http://www.vivo.com.br/conteudosmartphone


(CAVEAT: If you're having networking issues and so you get a neterror page instead of a redirect, *then* I think you can remove the bookmark -- when you're at the neterror page. This obviously isn't an ideal step to rely on for bookmark-removal, though.)

Comment 1

[Ben Francis [:benfrancis]]

Hmm, good catch.

I'm actually not sure how to go about fixing this.

The original design was that you should be able to long press a bookmark in the bookmark list to edit or delete it, but this feature was dropped from v1 because of bugs with the context menu.

I'm nominating this for blocking-basecamp? as I would like a group decision to be made, but I feel this should probably be basecamp-blocking-

It's not pretty, but there's potentially a workaround by quickly pressing the stop button before the page redirects.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't think that that workaround will work very well since redirects happen very fast. I'm still not sure that this is a blocker though.

Comment 3

[Ben Francis [:benfrancis]]

In triage this was judged as blocking-basecamp- because it's actually very difficult to create a bookmark yourself which goes to a redirect unless the redirect gets added later, there's a potential workaround (if very difficult) and the default bookmarks may be changed to URLs which don't redirect.

This should be fixed in V2 by adding the long press to delete feature.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This was eventually fixed.

Comment 6

[Daniel Holbert [:dholbert]]

Yup -- long-pressing a bookmark now brings up a full-screen context menu with an "Unbookmark" option, in my local b2g trunk build from ~2 weeks ago.

--> VERIFIED that this was fixed