838282 - Allow restricted group membership

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P3)

Description

[William Reynolds [:williamr]]

Mozillians currently has one group with restricted membership (staff), and there are other use cases for having groups with this behavior. The immediate use case is for recognizing Mozillians, such as the new Emeritus role: https://groups.google.com/forum/?fromgroups=#!topic/mozilla.governance/WVmEf2_spb0

User stories:
- As an admin, I can change if a group has restricted membership or not.
- As an admin, I can add multiple users to a restricted group in one action.
- As a user, I do not see a 'Join Group' button when viewing a group with restricted membership.
- As a user, I can leave a restricted group I am a member in. (Same behavior as any group)

No need for UX changes or new strings for users at this point, since all requests to add people to restricted groups will be handled by admins.

Comment 1

[William Reynolds [:williamr]]

To allow this feature to solve more use cases, I suggest changing the requirements in comment 0 to simply have two check boxes in the group admin panel: allow users to join and allow users to leave. Both of these are checked by default.

Revised user stories:
- As an admin, I can change if a group allows users to join, leave or both.
- As an admin, I can add or multiple users to a group in one action.
- As a user, I do not see a 'Join Group' button when viewing a group that has 'allow users to join' disabled.
- As a user, I do not see a 'Leave Group' button when viewing a group that has 'allow users to leave' disabled.
- As a user, I cannot join a group that has 'allow users to join' disabled.
- As a user, I cannot leave a group that has 'allow users to leave' disabled.

Comment 2

[William Reynolds [:williamr]]

(In reply to William Reynolds [:williamr] from comment #1)
> - As an admin, I can add or multiple users to a group in one action.

It feels like we do this fairly easily with two multi-select boxes with arrows for moving items between the selected and non-selected states, along with "Choose All" and "Clear All" options. We already use for approach with the 'User permissions' field for editing a user in the admin panel.

I'd like to see both multi-select boxes have a filter, so as an admin, I can quickly search by name and add/remove people to a group.

Reference: https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.ManyToManyField

Comment 3

[William Reynolds [:williamr]]

Attachment: Multi-select boxes example

Here's how the multi-select boxes appear for the user permissions field in the admin panel.

Comment 4

[Justin Crawford [:hoosteeno] [:jcrawford]]

The revised spec in comment 1, "have two check boxes in the group admin panel: allow users to join and allow users to leave", was accomplished with bug 936569. Can we mark this bug as resolved?

Comment 5

[William Reynolds [:williamr]]

(In reply to Justin Crawford [:hoosteeno] from comment #4)
> The revised spec in comment 1, "have two check boxes in the group admin
> panel: allow users to join and allow users to leave", was accomplished with
> bug 936569. Can we mark this bug as resolved?

Certainly. This is fixed. Thank you, curated groups!

Comment 6

[Matt Brandt [:mbrandt]]

Bumping to QA verified!