Closed
Bug 838364
Opened 11 years ago
Closed 11 years ago
Progress bar is not visible while start/autocomplete is showing and "Always show tabs" is enabled
Categories
(Firefox for Metro Graveyard :: Browser, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
3.59 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
We need to move the progressbar up so that it's right under the toolbar, even when the start UI is visible. Since the start-container can't cover up the bottom toolbar border with a negative margin now, we explicitly remove the border instead. The patch depends on bug 837396, whose patches in turn depend on bug 838222.
Attachment #710421 -
Flags: review?(jmathies)
Comment 1•11 years ago
|
||
Does this mean the progress meter shifts the start page down by 3px when it's visible? I wonder if there will be some visible shifting.
Updated•11 years ago
|
Attachment #710421 -
Attachment is patch: true
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #1) > Does this mean the progress meter shifts the start page down by 3px when > it's visible? I wonder if there will be some visible shifting. No, the patch adds a negative margin on the progress meter which exactly offsets its height, so it has no effect on the layout of its siblings.
Updated•11 years ago
|
Attachment #710421 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 3•11 years ago
|
||
http://hg.mozilla.org/projects/elm/rev/7eaa1b511c1e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 4•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; rv:22.0) Gecko/20130327 Firefox/22.0 With "show tabs enabled" there is no navigation progress bar indicator in Windows 8 for Firefox Metro. Reopened? New bug?
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•