838526 - make package broken due to missing packages (Port Firefox bugs: Bug 831683 and Bug 836206).

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Edmund Wong (:ewong)]

make package under Linux64 build is busted:

make[1]: Entering directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make export
make[2]: Entering directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make[2]: Nothing to be done for `export'.
make[2]: Leaving directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make libs
make[2]: Entering directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make make-package-internal
make[3]: Entering directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
/builds/slave/c-cen-t-lnx64/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx64/build/mozilla/config/Preprocessor.py -DMOZ_GLUE_IN_PROGRAM -DMOZ_SUITE=1 -DOSTYPE=\"Linux2.6.18-53.1.14\" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=seamonkey -DPREF_DIR=defaults/pref -DJAREXT= -DENABLE_TESTS=1 -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK2=1 -DMOZ_PACKAGE_DEBUGQA=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_UPDATER=1 -DMOZ_MOVEMAIL=1 -DNECKO_WIFI=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DBINPATH=bin -DHAVE_64BIT_OS=1 -DMOZILLA_VERSION=\"21.0a1\" -DMOZILLA_VERSION_U=21.0a1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_SSIZE_T=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_UINT=1 -DHAVE_UNAME_DOMAINNAME_FIELD=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_SYS_BITYPES_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_GNU_LIBC_VERSION_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_CDEFS_H=1 -DHAVE_LIBM=1 -DHAVE_DLADDR=1 -DFUNCPROTO=15 -D_REENTRANT=1 -DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1 -DHAVE_LSTAT64=1 -DHAVE_TRUNCATE64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1 -DHAVE_RES_NINIT=1 -DHAVE_GNU_GET_LIBC_VERSION=1 -DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DHAVE_VA_LIST_AS_ARRAY=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DMALLOC_H=\<malloc.h\> -DHAVE_STRNDUP=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_MEMALIGN=1 -DHAVE_VALLOC=1 -DHAVE_I18N_LC_MESSAGES=1 -DHAVE_LOCALECONV=1 -DNS_ALWAYS_INLINE=__attribute__\(\(always_inline\)\) -DNS_ATTR_MALLOC=__attribute__\(\(malloc\)\) -DNS_WARN_UNUSED_RESULT=__attribute__\(\(warn_unused_result\)\) -DNS_NORETURN=__attribute__\(\(noreturn\)\) -DMOZ_SUITE=1 -DMOZ_BUILD_APP=suite -DMOZ_X11=1 -DMOZ_WIDGET_GTK2=1 -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_GNOMEVFS=1 -DMOZ_ENABLE_DBUS=1 -DIBMBIDI=1 -DACCESSIBILITY=1 -DNS_PRINTING=1 -DMOZ_XTF=1 -DMOZ_CRASHREPORTER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_HELP_VIEWER=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_DEBUG_SYMBOLS=1 -DMOZ_LOGGING=1 -DSIZEOF_INT_P=8 -DMOZ_MEMORY_SIZEOF_PTR_2POW=3 -DMOZ_MEMORY=1 -DMOZ_MEMORY_LINUX=1 -DHAVE_JEMALLOC_VALLOC=1 -DHAVE_JEMALLOC_POSIX_MEMALIGN=1 -DHAVE_JEMALLOC_MEMALIGN=1 -DMOZ_ENABLE_PROFILER_SPS=1 -DHAVE___CXA_DEMANGLE=1 -DHAVE__UNWIND_BACKTRACE=1 -DMOZ_OMNIJAR=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_STATIC_JS=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DNECKO_WIFI=1 -DBUILD_CTYPES=1 -DMOZ_MORK=1 -DMOZ_MORKREADER=1 -DMOZ_PLACES=1 -DMOZ_SERVICES_AITC=1 -DMOZ_SERVICES_COMMON=1 -DMOZ_SERVICES_CRYPTO=1 -DMOZ_SERVICES_SYNC=1 -DMOZ_UA_BUILDID=\"20100101\" -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DMOZ_ACCESSIBILITY_ATK=1 -DATK_MAJOR_VERSION=1 -DATK_MINOR_VERSION=12 -DATK_REV_VERSION=2 /builds/slave/c-cen-t-lnx64/build/suite/installer/package-manifest.in > package-manifest
/builds/slave/c-cen-t-lnx64/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx64/build/mozilla/toolkit/mozapps/installer/packager.py -DMOZ_GLUE_IN_PROGRAM -DMOZ_SUITE=1 -DOSTYPE=\"Linux2.6.18-53.1.14\" -DOSARCH=Linux -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=seamonkey -DPREF_DIR=defaults/pref -DJAREXT= -DENABLE_TESTS=1 -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK2=1 -DMOZ_PACKAGE_DEBUGQA=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_UPDATER=1 -DMOZ_MOVEMAIL=1 -DNECKO_WIFI=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DBINPATH=bin \
		--format omni \
		--removals /builds/slave/c-cen-t-lnx64/build/suite/installer/removed-files.in \
		 \
		 \
		--jarlogs /builds/slave/c-cen-t-lnx64/build/objdir/suite/installer/../../jarlog//en-US \
		--optimizejars \
		 \
		package-manifest ../../mozilla/dist ../../mozilla/dist/seamonkey \
		--non-resource defaults/messenger/mailViews.dat defaults/profile/localstore.rdf defaults/profile/panels.rdf 
Error: /builds/slave/c-cen-t-lnx64/build/objdir/suite/installer/package-manifest:233: Missing file(s): bin/components/Aitc.js
Error: /builds/slave/c-cen-t-lnx64/build/objdir/suite/installer/package-manifest:234: Missing file(s): bin/components/AitcComponents.manifest
Traceback (most recent call last):
  File "/builds/slave/c-cen-t-lnx64/build/mozilla/toolkit/mozapps/installer/packager.py", line 364, in <module>
    main()
  File "/builds/slave/c-cen-t-lnx64/build/mozilla/toolkit/mozapps/installer/packager.py", line 320, in main
    copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
  File "/tools/python-2.7.2/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/builds/slave/c-cen-t-lnx64/build/mozilla/python/mozbuild/mozpack/errors.py", line 129, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
make[3]: *** [stage-package] Error 1
make[3]: Leaving directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make[2]: *** [make-package] Error 2
make[2]: Leaving directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx64/build/objdir/suite/installer'
make: *** [package] Error 2
program finished with exit code 2

Comment 1

[Edmund Wong (:ewong)]

cc'ing mcsmurf

Comment 2

[Philip Chee]

Attachment: Patch v1.0 Package it.

Referenced Firefox bugs:
Bug 831683 - B2G SMS & B2G MMS: make SMS database more generic for MMS (part 2, create dom/mobilemessage to put DB codes).
Bug 836206 - Remove AITC client.

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 710714 [details] [diff] [review]
Patch v1.0 Package it.

r+ with this fixed:
+greprefs/services-aitc.js

You don't need this, it's already listed as defaults/pref/services-aitc.js in the #ifdef MOZ_OMNIJAR section (and in the #else clause, too, see the other change in your patch).

Comment 4

[Frank Wein [:mcsmurf]]

And with "fixed" I mean: Remove this line :)

Comment 5

[Philip Chee]

> +greprefs/services-aitc.js

> You don't need this, it's already listed as defaults/pref/services-aitc.js in
> the #ifdef MOZ_OMNIJAR section (and in the #else clause, too, see the other change
> in your patch).

> And with "fixed" I mean: Remove this line :)
Done.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/ec86d80bfaf7