Closed Bug 838582 Opened 8 years ago Closed 8 years ago

Convert HTMLTextAreaElement to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

I plan on working on this on the plane...
Attachment #715293 - Flags: review?(bzbarsky)
With a couple of more test fixes.
Attachment #715293 - Attachment is obsolete: true
Attachment #715293 - Flags: review?(bzbarsky)
Attachment #715317 - Flags: review?(bzbarsky)
Comment on attachment 715292 [details] [diff] [review]
Part 1: Rename nsHTMLTextAreaElement to mozilla::dom::HTMLTextAreaElement

r=me
Attachment #715292 - Flags: review?(bzbarsky) → review+
Comment on attachment 715317 [details] [diff] [review]
Part 2: Move HTMLTextAreaElement to Web IDL bindings

Document that the XPCOM GetType is ok?

Same thing for GetDefaultValue and Get/SetValue.  And Select().

You need to declare and implement a "textLength" getter.  Right now I believe you're ending up calling FragmentOrElement::TextLength, which is no good.  And to avoid name-colliding with that, you might need a binaryname annotation... and presumably a test, if this passed try.  :(

You need a WebIDL version of "controllers", presumably ChromeOnly.  Again, might need a test if we didn't have one already.

r=me with those nits.
Attachment #715317 - Flags: review?(bzbarsky) → review+
Part 1 checked in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6441636bcf58

I will address the rest of the comments and check in part 2 at some point!
Whiteboard: [leave open]
Attachment #715317 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/cb2935e08f2c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.