838582 - Convert HTMLTextAreaElement to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

I plan on working on this on the plane...

Comment 1

[(no longer active)]

Attachment: Part 1: Rename nsHTMLTextAreaElement to mozilla::dom::HTMLTextAreaElement

Comment 2

[(no longer active)]

Attachment: Part 2: Move HTMLTextAreaElement to Web IDL bindings

Comment 3

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=356ef44a5e73

Comment 4

[(no longer active)]

Attachment: Part 2: Move HTMLTextAreaElement to Web IDL bindings

With a couple of more test fixes.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 715292 [details] [diff] [review]
Part 1: Rename nsHTMLTextAreaElement to mozilla::dom::HTMLTextAreaElement

r=me

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 715317 [details] [diff] [review]
Part 2: Move HTMLTextAreaElement to Web IDL bindings

Document that the XPCOM GetType is ok?

Same thing for GetDefaultValue and Get/SetValue.  And Select().

You need to declare and implement a "textLength" getter.  Right now I believe you're ending up calling FragmentOrElement::TextLength, which is no good.  And to avoid name-colliding with that, you might need a binaryname annotation... and presumably a test, if this passed try.  :(

You need a WebIDL version of "controllers", presumably ChromeOnly.  Again, might need a test if we didn't have one already.

r=me with those nits.

Comment 7

[(no longer active)]

Part 1 checked in:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6441636bcf58

I will address the rest of the comments and check in part 2 at some point!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6441636bcf58

Comment 9

[(no longer active)]

Attachment: Part 2: Move HTMLTextAreaElement to Web IDL bindings

Comment 10

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87ab1cbdcea3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

This got caught up in another backout due to conflicting changes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca34c11bf55d

Re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb2935e08f2c

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/cb2935e08f2c