838598 - Convert HTMLMenuItemElement to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - renaming

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - webidl

Comment 3

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=f271d2ba7b15 I hope it's green!

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 710837 [details] [diff] [review]
part 1 - renaming

Review of attachment 710837 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLMenuItemElement.h
@@ +20,5 @@
>  public:
>    using mozilla::dom::Element::GetText;
>  
> +  HTMLMenuItemElement(already_AddRefed<nsINodeInfo> aNodeInfo,
> +                      mozilla::dom::FromParser aFromParser);

Drop the mozilla::dom:: here and above

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 710839 [details] [diff] [review]
part 2 - webidl

Review of attachment 710839 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLMenuItemElement.h
@@ +84,5 @@
> +
> +  // The XPCOM GetLabel is OK for us
> +  void SetLabel(const nsAString& aLabel, ErrorResult& aError)
> +  {
> +    SetAttrHelper(nsGkAtoms::label, aLabel);

SetHTMLAttr

@@ +90,5 @@
> +
> +  // The XPCOM GetIcon is OK for us
> +  void SetIcon(const nsAString& aIcon, ErrorResult& aError)
> +  {
> +    SetAttrHelper(nsGkAtoms::icon, aIcon);

Same here

@@ +108,5 @@
> +    return mChecked;
> +  }
> +  void SetChecked(bool aChecked, ErrorResult& aError)
> +  {
> +    aError = SetChecked(aChecked);

This can't throw. Just using the XPCOM one is fine, but add a comment.

@@ +128,5 @@
> +  }
> +
> +protected:
> +  virtual JSObject* WrapNode(JSContext *aCx, JSObject *aScope,
> +                             bool *aTriedToWrap) MOZ_OVERRIDE;

* to the left

::: dom/webidl/HTMLMenuItemElement.webidl
@@ +11,5 @@
> + * and create derivative works of this document.
> + */
> +
> +// http://www.whatwg.org/specs/web-apps/current-work/#the-menuitem-element
> +interface HTMLMenuItemElement : HTMLElement {

All this used to be on HTMLCommandElement in our implementation... Please confirm with janv this is fine.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> SetHTMLAttr

And pass aError to it, too?

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 2 - webidl (b)

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Anything blocking this?

Comment 9

[Jan Varga [:janv]]

Comment on attachment 710839 [details] [diff] [review]
part 2 - webidl

r=me, but I think we should mention the interface change in https://developer.mozilla.org/en-US/docs/Firefox_21_for_developers
So, don't forget to update it

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: part 1 - renaming

Merged to tip for Ryan :)

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: part 2 - webidl

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8497cf15a6dc
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa2b18fae9c

Comment 13

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/8497cf15a6dc
https://hg.mozilla.org/mozilla-central/rev/3fa2b18fae9c