Closed Bug 838598 Opened 7 years ago Closed 7 years ago

Convert HTMLMenuItemElement to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

No description provided.
Attached patch part 1 - renaming (obsolete) — Splinter Review
Attachment #710837 - Flags: review?(Ms2ger)
Attached patch part 2 - webidl (obsolete) — Splinter Review
Attachment #710839 - Flags: review?(Ms2ger)
Comment on attachment 710837 [details] [diff] [review]
part 1 - renaming

Review of attachment 710837 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLMenuItemElement.h
@@ +20,5 @@
>  public:
>    using mozilla::dom::Element::GetText;
>  
> +  HTMLMenuItemElement(already_AddRefed<nsINodeInfo> aNodeInfo,
> +                      mozilla::dom::FromParser aFromParser);

Drop the mozilla::dom:: here and above
Attachment #710837 - Flags: review?(Ms2ger) → review+
Comment on attachment 710839 [details] [diff] [review]
part 2 - webidl

Review of attachment 710839 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLMenuItemElement.h
@@ +84,5 @@
> +
> +  // The XPCOM GetLabel is OK for us
> +  void SetLabel(const nsAString& aLabel, ErrorResult& aError)
> +  {
> +    SetAttrHelper(nsGkAtoms::label, aLabel);

SetHTMLAttr

@@ +90,5 @@
> +
> +  // The XPCOM GetIcon is OK for us
> +  void SetIcon(const nsAString& aIcon, ErrorResult& aError)
> +  {
> +    SetAttrHelper(nsGkAtoms::icon, aIcon);

Same here

@@ +108,5 @@
> +    return mChecked;
> +  }
> +  void SetChecked(bool aChecked, ErrorResult& aError)
> +  {
> +    aError = SetChecked(aChecked);

This can't throw. Just using the XPCOM one is fine, but add a comment.

@@ +128,5 @@
> +  }
> +
> +protected:
> +  virtual JSObject* WrapNode(JSContext *aCx, JSObject *aScope,
> +                             bool *aTriedToWrap) MOZ_OVERRIDE;

* to the left

::: dom/webidl/HTMLMenuItemElement.webidl
@@ +11,5 @@
> + * and create derivative works of this document.
> + */
> +
> +// http://www.whatwg.org/specs/web-apps/current-work/#the-menuitem-element
> +interface HTMLMenuItemElement : HTMLElement {

All this used to be on HTMLCommandElement in our implementation... Please confirm with janv this is fine.
Attachment #710839 - Flags: review?(Ms2ger) → review+
> SetHTMLAttr

And pass aError to it, too?
Attached patch part 2 - webidl (b) (obsolete) — Splinter Review
Attachment #710839 - Attachment is obsolete: true
Attachment #711342 - Flags: review?(peterv)
Attachment #711342 - Attachment is obsolete: true
Attachment #711342 - Flags: review?(peterv)
Attachment #710839 - Attachment is obsolete: false
Anything blocking this?
Attachment #710839 - Flags: review?(Jan.Varga)
Attachment #710837 - Flags: review?(Jan.Varga)
Attachment #710837 - Flags: review?(Jan.Varga) → review+
Comment on attachment 710839 [details] [diff] [review]
part 2 - webidl

r=me, but I think we should mention the interface change in https://developer.mozilla.org/en-US/docs/Firefox_21_for_developers
So, don't forget to update it
Attachment #710839 - Flags: review?(Jan.Varga) → review+
Keywords: checkin-needed
Merged to tip for Ryan :)
Attachment #710837 - Attachment is obsolete: true
Attachment #715064 - Flags: review+
Attached patch part 2 - webidlSplinter Review
Attachment #710839 - Attachment is obsolete: true
Attachment #715065 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/8497cf15a6dc
https://hg.mozilla.org/mozilla-central/rev/3fa2b18fae9c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.