838672 - [Browser] Default tab title "[object Object]"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Rick Waldron [:rwaldron]]

Attachment: Screenshot of default tab title in emulator

See attachment

Comment 1

[Rick Waldron [:rwaldron]]

Appears that the var "title" is not a string, but an object:

{
  _payload_: "",
  msg_name: "titlechange"
}

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I see the following if I interrupt a site's load (usually before it's loaded the 1st time) by clicking refresh/reload:

E/GeckoConsole(  109): [JavaScript Error: "Image corrupt or truncated: blob:8efc70e3-ad64-4ce6-b677-8a285705b2cc" {file: "blob:8efc70e3-ad64-4ce6-b677-8a285705b2cc" line: 0}]

<snip> - just a bunch of D/memalloc stuff

E/GeckoConsole(  763): [JavaScript Warning: "Unknown property '-moz-align-self'.  Declaration dropped." {file: "resource://gre-resources/ua.css" line: 44}]

<snip>  - more of the same

I/Gecko   (  763): ###################################### forms.js loaded

<snip> yet more D/memalloc stuff (no errors or warnings, that I can see)

E/GeckoConsole(  109): [JavaScript Error: "DataCloneError: The object could not be cloned." {file: "app://browser.gaiamobile.org/js/places.js" line: 737}]

Comment 3

[Rick Waldron [:rwaldron]]

Sorry, I'm not sure I see the connection, can you clarify? I've boiled it down to a much simpler issue, where the `tab.title` is naively being set to whatever the value of `evt.detail` in `mozbrowsertitlechange` events. Since `generateTabLi` expects `tab.title` to be a string, but never bothers to ensure that it is, the tab text is set to the value of `tab.title`, regardless of the value. In this case, the object's toString is called and the text is set to [object Object].

Comment 4

[Rick Waldron [:rwaldron]]

Attachment: Fix

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: Screenshot of default tab title in emulator - FIXED

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 710903 [details] [diff] [review]
Fix

The value is supposed to be a string, not an object.

This was caused by a regression in the platform which will be fixed in bug 837317 so I don't think this workaround in Gaia is necessary because if the API is working correctly it should always return a string. But thank you anyway.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Ben Francis [:benfrancis] from comment #6)
> Comment on attachment 710903 [details] [diff] [review]
> Fix
> 
> The value is supposed to be a string, not an object.
> 
> This was caused by a regression in the platform which will be fixed in bug
> 837317 so I don't think this workaround in Gaia is necessary because if the
> API is working correctly it should always return a string. But thank you
> anyway.

so should this be resolved as won't fix?

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] from comment #7)
> (In reply to Ben Francis [:benfrancis] from comment #6)
> > Comment on attachment 710903 [details] [diff] [review]
> > Fix
> > 
> > The value is supposed to be a string, not an object.
> > 
> > This was caused by a regression in the platform which will be fixed in bug
> > 837317 so I don't think this workaround in Gaia is necessary because if the
> > API is working correctly it should always return a string. But thank you
> > anyway.
> 
> so should this be resolved as won't fix?

s/wont fix/WFM

Comment 9

[Rick Waldron [:rwaldron]]

Resolved elsewhere

Comment 10

[Rick Waldron [:rwaldron]]

Resolved https://bugzilla.mozilla.org/show_bug.cgi?id=837317