838676 - GetDisplayFileName() should only return the file name, not the file path

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efa7756f90a4

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efa7756f90a4

Comment 3

[Milan Crha]

That's a very bad idea, causing usability regression. And here is absolutely no reason given why this decision is good.

Could you explain why you think the change is a good change, please? 

I do not know how you, but my disk contains several folders with exactly the same file names in there [1], but different content, and an ability to see that I'm going to upload a file from the right folder is the mandatory requirement. Please revert the change in the next release.

[1] $ find /usr/share/icons/ -name go-down.png | wc -l
    37

Comment 4

[Mounir Lamouri (:mounir)]

Having the full path wasn't working well because it wasn't readable at all and wasn't working for multiple files. I opened bug 891924 to get UX feedback on this issues though.