Closed
Bug 838675
Opened 12 years ago
Closed 12 years ago
Make <input type='file'> rendering nicer (keep up with other browsers)
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
relnote-firefox | --- | 23+ |
People
(Reporter: mounir, Assigned: mounir)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: meta)
This is a meta bug about improving our <input type='file'> widget. The goal of this bug is reaching other vendors quality. There will be other bugs about going farther.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Try builds with with all patches applied:
https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mlamouri@mozilla.com-b61257dc2541/
Assignee | ||
Comment 2•12 years ago
|
||
Just to make sure I'm not introducing a grammatical mistake... When there is no file selected on a file input, the message is "No file selected.", when there is the multiple attribute, it is "No files selected.". Is the plural for 'file' correct here?
Assignee | ||
Updated•12 years ago
|
Blocks: CVE-2013-1671
Comment 3•12 years ago
|
||
(In reply to Mounir Lamouri (:mounir) from comment #2)
> Just to make sure I'm not introducing a grammatical mistake... When there is
> no file selected on a file input, the message is "No file selected.", when
> there is the multiple attribute, it is "No files selected.". Is the plural
> for 'file' correct here?
Yes.
Assignee | ||
Updated•12 years ago
|
Comment 4•12 years ago
|
||
Who in UX is helping with the visual design / UX of these changes?
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #4)
> Who in UX is helping with the visual design / UX of these changes?
No one I'm afraid.
Comment 6•12 years ago
|
||
Ah! Best to get UX involved early, but it's never too late. :)
What should we use to take a look? Is it all in Nightly now, or would another Try build be useful?
Any test pages to exercise it?
Assignee | ||
Comment 7•12 years ago
|
||
It is in Nightly. I guess you can simply use: data:text/html,<input type='file'> or the bugzilla attachment page to try it.
Assignee | ||
Comment 8•12 years ago
|
||
All dependant bugs are resolved, marking this meta bug as resolved fixed then.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
relnote-firefox:
--- → ?
Comment 9•11 years ago
|
||
We already have a note about the input implementation:
DEVELOPER
HTML5 <input type="range"> form control implemented
Is there something you'd like added or changed about this note to reflect this bug? If so please email me or ping in IRC.
Flags: needinfo?(mounir)
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to lsblakk@mozilla.com [:lsblakk] from comment #9)
> We already have a note about the input implementation:
>
> DEVELOPER
> HTML5 <input type="range"> form control implemented
>
> Is there something you'd like added or changed about this note to reflect
> this bug? If so please email me or ping in IRC.
This bug is about <input type='file'>, not <input type='range'>.
Flags: needinfo?(mounir)
Comment 11•11 years ago
|
||
Ah, ok then.
Added: <input type='file'> rendering improvements (see <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=838675">bug 838675</a>)<
You need to log in
before you can comment on or make changes to this bug.
Description
•