838675 - Make <input type='file'> rendering nicer (keep up with other browsers)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mounir Lamouri (:mounir)]

This is a meta bug about improving our <input type='file'> widget. The goal of this bug is reaching other vendors quality. There will be other bugs about going farther.

Comment 1

[Mounir Lamouri (:mounir)]

Try builds with with all patches applied:
https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b61257dc2541/

Comment 2

[Mounir Lamouri (:mounir)]

Just to make sure I'm not introducing a grammatical mistake... When there is no file selected on a file input, the message is "No file selected.", when there is the multiple attribute, it is "No files selected.". Is the plural for 'file' correct here?

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Mounir Lamouri (:mounir) from comment #2)
> Just to make sure I'm not introducing a grammatical mistake... When there is
> no file selected on a file input, the message is "No file selected.", when
> there is the multiple attribute, it is "No files selected.". Is the plural
> for 'file' correct here?

Yes.

Comment 4

[Justin Dolske [:Dolske]]

Who in UX is helping with the visual design / UX of these changes?

Comment 5

[Mounir Lamouri (:mounir)]

(In reply to Justin Dolske [:Dolske] from comment #4)
> Who in UX is helping with the visual design / UX of these changes?

No one I'm afraid.

Comment 6

[Justin Dolske [:Dolske]]

Ah! Best to get UX involved early, but it's never too late. :)

What should we use to take a look? Is it all in Nightly now, or would another Try build be useful?

Any test pages to exercise it?

Comment 7

[Mounir Lamouri (:mounir)]

It is in Nightly. I guess you can simply use: data:text/html,<input type='file'> or the bugzilla attachment page to try it.

Comment 8

[Mounir Lamouri (:mounir)]

All dependant bugs are resolved, marking this meta bug as resolved fixed then.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

We already have a note about the input implementation:

 DEVELOPER
HTML5 <input type="range"> form control implemented 

Is there something you'd like added or changed about this note to reflect this bug? If so please email me or ping in IRC.

Comment 10

[Mounir Lamouri (:mounir)]

(In reply to [e-mail] [:lsblakk] from comment #9)
> We already have a note about the input implementation:
> 
>  DEVELOPER
> HTML5 <input type="range"> form control implemented 
> 
> Is there something you'd like added or changed about this note to reflect
> this bug? If so please email me or ping in IRC.

This bug is about <input type='file'>, not <input type='range'>.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Ah, ok then.

Added: <input type='file'> rendering improvements (see <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=838675">bug 838675</a>)<