Closed Bug 838675 Opened 8 years ago Closed 8 years ago

Make <input type='file'> rendering nicer (keep up with other browsers)

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
relnote-firefox --- 23+

People

(Reporter: mounir, Assigned: mounir)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: meta)

This is a meta bug about improving our <input type='file'> widget. The goal of this bug is reaching other vendors quality. There will be other bugs about going farther.
Depends on: 838676
Depends on: 345195
Depends on: 838694
Depends on: 838695
Depends on: 838354
Depends on: 838698
Depends on: 838699
Depends on: 838703
Depends on: 838704
Depends on: 838705
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Depends on: 762270
Just to make sure I'm not introducing a grammatical mistake... When there is no file selected on a file input, the message is "No file selected.", when there is the multiple attribute, it is "No files selected.". Is the plural for 'file' correct here?
Depends on: 839787
Depends on: 839788
Depends on: 839060
Depends on: 847233
(In reply to Mounir Lamouri (:mounir) from comment #2)
> Just to make sure I'm not introducing a grammatical mistake... When there is
> no file selected on a file input, the message is "No file selected.", when
> there is the multiple attribute, it is "No files selected.". Is the plural
> for 'file' correct here?

Yes.
Blocks: 839060
No longer depends on: 839060
Who in UX is helping with the visual design / UX of these changes?
(In reply to Justin Dolske [:Dolske] from comment #4)
> Who in UX is helping with the visual design / UX of these changes?

No one I'm afraid.
Ah! Best to get UX involved early, but it's never too late. :)

What should we use to take a look? Is it all in Nightly now, or would another Try build be useful?

Any test pages to exercise it?
It is in Nightly. I guess you can simply use: data:text/html,<input type='file'> or the bugzilla attachment page to try it.
All dependant bugs are resolved, marking this meta bug as resolved fixed then.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
relnote-firefox: --- → ?
Depends on: 857409
Depends on: 891924
We already have a note about the input implementation:

 DEVELOPER
HTML5 <input type="range"> form control implemented 

Is there something you'd like added or changed about this note to reflect this bug? If so please email me or ping in IRC.
Flags: needinfo?(mounir)
(In reply to lsblakk@mozilla.com [:lsblakk] from comment #9)
> We already have a note about the input implementation:
> 
>  DEVELOPER
> HTML5 <input type="range"> form control implemented 
> 
> Is there something you'd like added or changed about this note to reflect
> this bug? If so please email me or ping in IRC.

This bug is about <input type='file'>, not <input type='range'>.
Flags: needinfo?(mounir)
Ah, ok then.

Added: <input type='file'> rendering improvements (see <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=838675">bug 838675</a>)<
You need to log in before you can comment on or make changes to this bug.