Make <input type='file'> rendering nicer (keep up with other browsers)

RESOLVED FIXED

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Depends on: 1 bug, Blocks: 1 bug, {meta})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 23+)

Details

(Assignee)

Description

4 years ago
This is a meta bug about improving our <input type='file'> widget. The goal of this bug is reaching other vendors quality. There will be other bugs about going farther.
(Assignee)

Updated

4 years ago
Depends on: 838676
(Assignee)

Updated

4 years ago
Depends on: 345195
(Assignee)

Updated

4 years ago
Depends on: 838694
(Assignee)

Updated

4 years ago
Depends on: 838695
(Assignee)

Updated

4 years ago
Depends on: 838354
(Assignee)

Updated

4 years ago
Depends on: 838698
(Assignee)

Updated

4 years ago
Depends on: 838699
(Assignee)

Updated

4 years ago
Depends on: 838703
(Assignee)

Updated

4 years ago
Depends on: 838704
(Assignee)

Updated

4 years ago
Depends on: 838705
(Assignee)

Updated

4 years ago
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Depends on: 762270
(Assignee)

Comment 1

4 years ago
Try builds with with all patches applied:
https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mlamouri@mozilla.com-b61257dc2541/
(Assignee)

Comment 2

4 years ago
Just to make sure I'm not introducing a grammatical mistake... When there is no file selected on a file input, the message is "No file selected.", when there is the multiple attribute, it is "No files selected.". Is the plural for 'file' correct here?
(Assignee)

Updated

4 years ago
Depends on: 839787
(Assignee)

Updated

4 years ago
Depends on: 839788
(Assignee)

Updated

4 years ago
Blocks: 842255
Depends on: 839060
(Assignee)

Updated

4 years ago
Depends on: 847233
(In reply to Mounir Lamouri (:mounir) from comment #2)
> Just to make sure I'm not introducing a grammatical mistake... When there is
> no file selected on a file input, the message is "No file selected.", when
> there is the multiple attribute, it is "No files selected.". Is the plural
> for 'file' correct here?

Yes.
(Assignee)

Updated

4 years ago
Blocks: 839060
No longer depends on: 839060
Who in UX is helping with the visual design / UX of these changes?
(Assignee)

Comment 5

4 years ago
(In reply to Justin Dolske [:Dolske] from comment #4)
> Who in UX is helping with the visual design / UX of these changes?

No one I'm afraid.
Ah! Best to get UX involved early, but it's never too late. :)

What should we use to take a look? Is it all in Nightly now, or would another Try build be useful?

Any test pages to exercise it?
(Assignee)

Comment 7

4 years ago
It is in Nightly. I guess you can simply use: data:text/html,<input type='file'> or the bugzilla attachment page to try it.
(Assignee)

Comment 8

4 years ago
All dependant bugs are resolved, marking this meta bug as resolved fixed then.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
relnote-firefox: --- → ?
Depends on: 857409
(Assignee)

Updated

4 years ago
Depends on: 891924
We already have a note about the input implementation:

 DEVELOPER
HTML5 <input type="range"> form control implemented 

Is there something you'd like added or changed about this note to reflect this bug? If so please email me or ping in IRC.
Flags: needinfo?(mounir)
(Assignee)

Comment 10

4 years ago
(In reply to lsblakk@mozilla.com [:lsblakk] from comment #9)
> We already have a note about the input implementation:
> 
>  DEVELOPER
> HTML5 <input type="range"> form control implemented 
> 
> Is there something you'd like added or changed about this note to reflect
> this bug? If so please email me or ping in IRC.

This bug is about <input type='file'>, not <input type='range'>.
Flags: needinfo?(mounir)
Ah, ok then.

Added: <input type='file'> rendering improvements (see <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=838675">bug 838675</a>)<
relnote-firefox: ? → 23+
You need to log in before you can comment on or make changes to this bug.