838694 - Move the text showing the file names to the right of the browse button for <input type='file'>

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 710787 [details] [diff] [review]
Patch

Why do we need to completely reorder everything in the function?  Seems like just changing the orders of the two AppendElement calls would do just as well...

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 710787 [details] [diff] [review]
Patch

That is true. I just used that patch to do some cleanup (remove para-phrasing comments, re-order stuff, etc.).

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK.  Next time, I'd love the cleanup separate from the substantive changes...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 710787 [details] [diff] [review]
Patch

>+  // Create and setup the file picking button.

This comment should come before we get the button's nodeinfo.

>+  mBrowse->SetNativeAnonymous();
>+  mBrowse->SetAttr(kNameSpaceID_None, nsGkAtoms::type,
>+                   NS_LITERAL_STRING("button"), false);

Please don't lose the comment about SetNativeAnonymous needing to come before SetAttr.

>+  // Create and setup the text showing the selected files.

Again, this should come before we get the nodeinfo, imo.

>-  // Mark the element to be native anonymous before setting any attributes.

Again, don't lose that comment.

r=me with that.

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f372d9cf7d5c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f372d9cf7d5c

Comment 7

[Milan Crha]

How can I turn this off, please? I do not like the change, I read from left to right, and the important part is the file name, and only then the button to browse for it. Definitely not the opposite. I do not see any good reason for this change, neither any explanation why you wanted to change this here. I consider this a usability regression, together with a fact that the file name entry is invisible now, thus I cannot see where its real estate is, thus clicking in an empty page space can bring a file chooser dialog, which is quite unexpected. Please see screen shots at [1], if you are unsure what I'm talking about. In case the entry invisibility is not caused by the button reorder, please point me to the right bug. Thanks in advance.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=981407

Comment 8

[Mounir Lamouri (:mounir)]

I am sympathetic to this problem and it will hopefully addressed in bug 891924.