838695 - Move nsFileControlFrame click handling to nsHTMLInputElement

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 710789 [details] [diff] [review]
Patch

r- per our discussion about how this causes click() to bring up two filepickers.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch

This is moving the click handling to the content.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Better patch, should pass tests.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 712139 [details] [diff] [review]
Patch v2

var e = new MouseEvent("click", {...}) looks a bit nicer than
var e = edocument.createEvent("MouseEvent");
e.initMouseEvent("click", ...);


s/DnDMouseListener/DnDListener/

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Fix clicking on the button

I will merge that patch with the main patch when landing but asking for a separate review to make the reviewer's life easier ;)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 715188 [details] [diff] [review]
Fix clicking on the button

"Returns if the element should prevent dispatching another DOMActivate." ->
"Returns true if the element should prevent dispatching another DOMActivate."

Comment 7

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e55e669d3ac

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e55e669d3ac