Closed Bug 838735 Opened 8 years ago Closed 8 years ago

Remove transparency from inactive tabs

Categories

(Firefox for Android :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 21
Tracking Status
firefox20 --- verified

People

(Reporter: ibarlow, Assigned: sriram)

References

Details

Attachments

(2 files)

Attached image screenshot of issue
Making inactive thumbnails slightly transparent seemed like a good idea in the design stage, but seeing it in Nightly has revealed some issues. 

1. Transparent thumbnails make the tabs tray feel very muted
2. Transparent thumbnails with no images cause the orange select colour to fill the entire rectangle, which is ugly

I would suggest simply making all thumbnails 100% opaque to fix this.
Attached patch PatchSplinter Review
Removed all transparency.
(Was that a performance win too? :-? )
Attachment #711464 - Flags: review?(mark.finkle)
Attachment #711464 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/c0ae5b372d21
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment on attachment 711464 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): UX issue.
User impact if declined: Transparent tabs.
Testing completed (on m-c, etc.): Landed in m-c on 02/08.
Risk to taking this patch (and alternatives if risky): Very low. Better performance!
String or UUID changes made by this patch: None.
Attachment #711464 - Flags: approval-mozilla-aurora?
Comment on attachment 711464 [details] [diff] [review]
Patch

low risk perf improvement needed for 817675., approving on aurora.
Attachment #711464 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-14), Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.