Remove transparency from inactive tabs

VERIFIED FIXED in Firefox 20

Status

()

defect
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: ibarlow, Assigned: sriram)

Tracking

unspecified
Firefox 21
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox20 verified)

Details

Attachments

(2 attachments)

Reporter

Description

6 years ago
Posted image screenshot of issue
Making inactive thumbnails slightly transparent seemed like a good idea in the design stage, but seeing it in Nightly has revealed some issues. 

1. Transparent thumbnails make the tabs tray feel very muted
2. Transparent thumbnails with no images cause the orange select colour to fill the entire rectangle, which is ugly

I would suggest simply making all thumbnails 100% opaque to fix this.
Posted patch PatchSplinter Review
Removed all transparency.
(Was that a performance win too? :-? )
Attachment #711464 - Flags: review?(mark.finkle)
Attachment #711464 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/c0ae5b372d21
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment on attachment 711464 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): UX issue.
User impact if declined: Transparent tabs.
Testing completed (on m-c, etc.): Landed in m-c on 02/08.
Risk to taking this patch (and alternatives if risky): Very low. Better performance!
String or UUID changes made by this patch: None.
Attachment #711464 - Flags: approval-mozilla-aurora?
Comment on attachment 711464 [details] [diff] [review]
Patch

low risk perf improvement needed for 817675., approving on aurora.
Attachment #711464 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 7

6 years ago
Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-14), Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.