838735 - Remove transparency from inactive tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: screenshot of issue

Making inactive thumbnails slightly transparent seemed like a good idea in the design stage, but seeing it in Nightly has revealed some issues. 

1. Transparent thumbnails make the tabs tray feel very muted
2. Transparent thumbnails with no images cause the orange select colour to fill the entire rectangle, which is ugly

I would suggest simply making all thumbnails 100% opaque to fix this.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Removed all transparency.
(Was that a performance win too? :-? )

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0ae5b372d21

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c0ae5b372d21

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 711464 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): UX issue.
User impact if declined: Transparent tabs.
Testing completed (on m-c, etc.): Landed in m-c on 02/08.
Risk to taking this patch (and alternatives if risky): Very low. Better performance!
String or UUID changes made by this patch: None.

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 711464 [details] [diff] [review]
Patch

low risk perf improvement needed for 817675., approving on aurora.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/648099fff122

Comment 7

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-14), Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1