838748 - Add visual touch feedback to entire tab row

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: mockup of change

Our new tab UI uses a border around the thumbnail to indicate that it's active. This is fine, but makes for a somewhat disconnected feeling when you touch anywhere else in the tab row and only the thumbnail is affected. 

Let's add a dark (30% black) background to the "touch" state.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This changes the pressed state to be 30% black.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51ef9db638f0

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/51ef9db638f0

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 711471 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Usability issue.
User impact if declined: No clear pressed state.
Testing completed (on m-c, etc.): Landed in m-c on 02/07
Risk to taking this patch (and alternatives if risky): Very low. Just a color change.
String or UUID changes made by this patch: None.

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/da9d24b6b678

Comment 6

[Andreea Pod]

Verified using HTC Desire Z (Android 2.3.3) on: Nightly 21.0a1(2013-02-10) and Aurora 20.0a2(2013-02-10).