Closed Bug 838807 Opened 12 years ago Closed 12 years ago

[Holo] Flatten all icons

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 fixed, firefox21 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 21
Tracking Flags:
Tracking Status
firefox20 --- fixed
firefox21 --- fixed

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(5 files)

Part 1: Replace tab icons
167.49 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Part 2: Replace tab carat
20.66 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Part 3: Remove tablet icons
5.74 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Part 4: Replace URL bar icons
30.87 KB, patch
bnicholson
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Part 5: Replace reader icons
46.01 KB, patch
bnicholson
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Flatten all icons to follow holo design.
This patch changes quite a lot of icons (and removes quite a lot of them too).
Attachment #710945 - Flags: review?(mark.finkle)
Blocks: 817675
Summary: Flatten all icons → [Holo] Flatten all icons
Attachment #710945 - Flags: review?(mark.finkle) → review+
This replaces the tab carats. The text color matches the carat color. The shadow needed a slight mis-alignment earlier. Now they are removed, and the alignment is made proper in XML file.
Attachment #711457 - Flags: review?(mark.finkle)
I missed removing tablet specific icons. Here they are.
Attachment #711498 - Flags: review?(mark.finkle)
Comment on attachment 711457 [details] [diff] [review] Part 2: Replace tab carat Do we need to keep all the various carat PNG images? Can we reduce the amount?
Attachment #711457 - Flags: review?(mark.finkle) → review+
Attachment #711498 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #7) > Comment on attachment 711457 [details] [diff] [review] > Part 2: Replace tab carat > > Do we need to keep all the various carat PNG images? Can we reduce the > amount? We would have to. The size of the text in landscape and portrait are different -- hence 2 sets. The size in 7" tablet is different -- hence one more set. The carats change direction in 10" tablets -- one more set. However, when lucas's patches land, we would be reusing 10" tablet ones on 7".
Sriram - Can we close this bug now?
(In reply to Mark Finkle (:mfinkle) from comment #11) > Sriram - Can we close this bug now? There's url-bar icons and reader-mode icons. Patches are on their way.
Comment on attachment 710945 [details] [diff] [review] Part 1: Replace tab icons [Approval Request Comment] Bug caused by (feature/regressing bug #): New UI. User impact if declined: Loss of more beautiful icons. Testing completed (on m-c, etc.): Landed in m-c on 02/07 Risk to taking this patch (and alternatives if risky): Very low. Just icons replaced. 127 of them :P String or UUID changes made by this patch: None.
Attachment #710945 - Flags: approval-mozilla-aurora?
Comment on attachment 711457 [details] [diff] [review] Part 2: Replace tab carat [Approval Request Comment] Bug caused by (feature/regressing bug #): New UI. User impact if declined: Loss of more beautiful icons. Testing completed (on m-c, etc.): Landed in m-c on 02/08 Risk to taking this patch (and alternatives if risky): Very low. Just icons replaced. String or UUID changes made by this patch: None.
Attachment #711457 - Flags: approval-mozilla-aurora?
Comment on attachment 711498 [details] [diff] [review] Part 3: Remove tablet icons [Approval Request Comment] Bug caused by (feature/regressing bug #): New UI. User impact if declined: Loss of more beautiful icons. Testing completed (on m-c, etc.): Landed in m-c on 02/08 Risk to taking this patch (and alternatives if risky): Very low. Just icons removed. String or UUID changes made by this patch: None.
Attachment #711498 - Flags: approval-mozilla-aurora?
Attachment #710945 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #711457 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #711498 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This replaces url bar icons. Also, the lock icon had a weird 21.33dp size and was scaling a 16dp icon to it. This is now replaced with a 20dp icon (that uses a 20dp image).
Attachment #712616 - Flags: review?(mark.finkle)
This replaces reader mode icons. As in URL bar, all icons will have same size on portrait, landscape and tablet modes (yaay! kill more icons). So, the CSS is refactored a bit to reflect that. And yaaay! Sriram worked on CSS after a loooong time!
Attachment #712618 - Flags: review?(mark.finkle)
Assignee: nobody → sriram
Attachment #712616 - Flags: review?(mark.finkle) → review+
Attachment #712618 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/9af3e9a47cc1 https://hg.mozilla.org/mozilla-central/rev/b39cc80812c9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Sriram, are you planning to request Aurora uplift for the last two patches? Otherwise, please set status-firefox20 to fixed please :)
status-firefox20: --- → affected
status-firefox21: --- → fixed
Comment on attachment 712616 [details] [diff] [review] Part 4: Replace URL bar icons [Approval Request Comment] Bug caused by (feature/regressing bug #): New UI. User impact if declined: Old icons with gradients. Testing completed (on m-c, etc.): Landed in m-c on 02/13. Risk to taking this patch (and alternatives if risky): Very low. Just icon replacement. String or UUID changes made by this patch: None.
Attachment #712616 - Flags: approval-mozilla-aurora?
Comment on attachment 712618 [details] [diff] [review] Part 5: Replace reader icons [Approval Request Comment] Bug caused by (feature/regressing bug #): New UI. User impact if declined: Old icons with gradients. Testing completed (on m-c, etc.): Landed in m-c on 02/13. Risk to taking this patch (and alternatives if risky): Very low. Just icon replacement. String or UUID changes made by this patch: None.
Attachment #712618 - Flags: approval-mozilla-aurora?
Attachment #712616 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #712618 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: