Closed
Bug 838820
Opened 11 years ago
Closed 11 years ago
BaselineCompiler: Compile NAME related opcodes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
18.72 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
JSOP_BINDNAME, JSOP_CALLNAME, JSOP_NAME, and JSOP_DELNAME are compiled by JM but not by Baseline. These can be handled as fallback ICs (except JSOP_DELNAME which can just be a stub call). With luke's upvar work none of these ops should be terribly hot anymore so at least for now we shouldn't need to generate any non-fallback ICs for them.
Assignee | ||
Comment 1•11 years ago
|
||
Patch for NAME and ALIASEDVAR opcodes. The ALIASEDVAR's are needed to test NAME related opcodes as the bytecode emitter uses these ops to set the 'arguments' var in scripts containing NAMEs.
Assignee: general → bhackett1024
Attachment #711323 -
Flags: review?(kvijayan)
Comment 2•11 years ago
|
||
Comment on attachment 711323 [details] [diff] [review] patch Review of attachment 711323 [details] [diff] [review]: ----------------------------------------------------------------- Nice. ALIASEDVAR and friends should help perf on v8 stuff quite a bit.
Attachment #711323 -
Flags: review?(kvijayan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/d0639bd4b896
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•