Mark ipc/unixsocket as FAIL_ON_WARNINGS

RESOLVED FIXED in mozilla21

Status

()

Core
IPC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 838756 leaves ipc/unixsocket build-warning-free.

Filing this bug on marking it as FAIL_ON_WARNINGS, to hopefully keep it that way.
Created attachment 710963 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #710963 - Flags: review?(kyle)
Comment on attachment 710963 [details] [diff] [review]
fix

Review of attachment 710963 [details] [diff] [review]:
-----------------------------------------------------------------

Well, um, it looks good, but I'm not really actually hitting the code that much these days, while the RIL and Bluetooth people are. So here's hoping I'm not signing my own death warrant by r+'ing this.
Attachment #710963 - Flags: review?(kyle) → review+
I'll gladly back you up, if anyone comes after you with a hatchet or anything. :)
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9793bcb3b7e0
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/9793bcb3b7e0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.