Closed
Bug 838840
Opened 11 years ago
Closed 11 years ago
Mark ipc/unixsocket as FAIL_ON_WARNINGS
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
669 bytes,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Bug 838756 leaves ipc/unixsocket build-warning-free. Filing this bug on marking it as FAIL_ON_WARNINGS, to hopefully keep it that way.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Try run (in progress, all green so far): https://tbpl.mozilla.org/?tree=Try&rev=3fed6971edff
|
||
Comment 3•11 years ago
|
||
Comment on attachment 710963 [details] [diff] [review] fix Review of attachment 710963 [details] [diff] [review]: ----------------------------------------------------------------- Well, um, it looks good, but I'm not really actually hitting the code that much these days, while the RIL and Bluetooth people are. So here's hoping I'm not signing my own death warrant by r+'ing this.
Attachment #710963 -
Flags: review?(kyle) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
I'll gladly back you up, if anyone comes after you with a hatchet or anything. :) Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/9793bcb3b7e0
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9793bcb3b7e0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•