838871 - [Contacts][E-mail Integration]: Facebook contacts do not show in the list of contacts when selecting “+” in “To”, “CC”, “bcc” when composing an email

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Misty Byrd]

Smoketest:
Unagi build#20130206110509
Gecko  a63eb9592fab5ccd3a3ad87767b3117f328710df

Gaia   9f5a4a9f6d321dbb4805f1f98623e770b0e8969
Kernel: Dec 5

Description:
When selecting “+” to add a contact when composing an email , the contact app does not render facebook imported contacts.
Prerequisites:
1.Have facebook contacts imported to device

Repro Steps:
1) Updated to Unagi Build ID 20130206110509
2) Select email app
3) Select top right icon to compose a new email
4) Select the “+” in “To”, “CC”, or “bcc”
5) Wait for contacts list to open


Expected:
All contacts with  an email available are shown

Actual:
No facebook contacts with emails are shown

Repro frequency:
(3/3 devices , 100% )
screenshots attached

Comment 1

[Misty Byrd]

Attachment: facebook contact with email

Comment 2

[Misty Byrd]

Attachment: facebook contact not available to select in email

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Moving this to contacts so the right eyes are on it; Kevin recently updated the filter, so this could be fallout from that.

Comment 4

[Misty Byrd]

correcting Gaia #:
Gaia   9f5a4a9f6d321dbb4805f1f98623e770b0e89698

Comment 5

[Misty Byrd]

correcting Gaia #:
Gaia   9f5a4a9f6d321dbb4805f1f98623e770b0e89698

Comment 6

[Jose Manuel Cantera]

this is a regression from bug 808650 which was landed without review from FB owners. There is no efficient  way of having FB Contacts available and showing only those Contacts who have an e-mail defined. Thus, as this bug is really blocking my proposal to fix this is to back out bug 808650.

Comment 7

[Jose Manuel Cantera]

furthermore this is how the SMS app works for instance with Contact pick and phone numbers. if the selected Contact in a Contact Pick activity has no phone numbers defined it shows a message to the user. Thus, for consistency reasons we should do the same with the e-mail app.

Comment 8

[Misty Byrd]

Smoketest regression:
This issue still repros in:
build#20130207070202
Kernel: Dec 5th
Gecko  cf1b9d27345e70daf242514733f848e76241ea1d
Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761

Comment 9

[Kevin Grandon :kgrandon]

Gah, this does appear to be a side effect of that changelist. I can go ahead and open up a pull request which backs that change out.

Comment 10

[Kevin Grandon :kgrandon]

A pull request has been opened to revert the commit that caused this: https://github.com/mozilla-b2g/gaia/pull/8014

Comment 11

[Jose Manuel Cantera]

I think we can merge this, as it is breaking a functionality. then we need to ask for an approval.

Comment 12

[Kevin Grandon :kgrandon]

I'm not 100% sure of the process, but I think we want to push this revert to the v1-train, to do that I think I nominate for leo?

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Github pull request - reverts bad patch

Comment 14

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/60b6cbfa0a2ff540c1d6ededd5d3a82c85827d65

Comment 15

[Jose Manuel Cantera]

Comment on attachment 712023 [details]
Github pull request - reverts bad patch

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): See bug details
User impact if declined: High 
Testing completed: 
Risk to taking this patch (and alternatives if risky): No risk

Comment 16

[Jose Manuel Cantera]

this should go to v1-train thus removing leo flag

Comment 17

[Alex Keybl [:akeybl]]

Comment on attachment 712023 [details]
Github pull request - reverts bad patch

We'll take a low risk backout for v1.0.1. Approving.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 87688cd2ef17184839867ab87f3668841af99a0d

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

Comment 20

[isabelrios]

Verified. Gecko-0ecc076.Gaia-4164424
When the contact has email, the email is added to the composer. If not, a message appears indicating that there is not any email