Decouple FHR from desktop-specific code

RESOLVED FIXED in Firefox 21

Status

RESOLVED FIXED
6 years ago
7 days ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
Firefox 21
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Uploading, UX triggering, pref management should all be abstracted in such a way that we can ship only relevant code on Android, and implement the equivalents in Java.
(Assignee)

Updated

6 years ago
Blocks: 828654
(Assignee)

Comment 1

6 years ago
Shortest term: allow Android to only write prefs, not call a JS function, when enabling or disabling.
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Blocks: 840129
(Assignee)

Updated

6 years ago
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Depends on: 840169
(Assignee)

Updated

6 years ago
Blocks: 840171
(Assignee)

Updated

6 years ago
Depends on: 838877
(Assignee)

Updated

6 years ago
No longer depends on: 840169
(Assignee)

Comment 2

6 years ago
Created attachment 713194 [details] [diff] [review]
Part 1: split out AbstractHealthReporter. v1

This splits out all of the logic that isn't concerned with uploading and prefs. This is step 1, with subsequent steps being to conditionalize the definition of HealthReporter and its bagheeraclient imports, define a class suitable for use on Android, and conditionally use that instead, and fix tests appropriately.

I was planning to define MOZ_USE_EXTERNAL_HEALTHREPORTER to control this; do you have an opinion?
Attachment #713194 - Flags: review?(gps)

Comment 3

6 years ago
Comment on attachment 713194 [details] [diff] [review]
Part 1: split out AbstractHealthReporter. v1

Review of attachment 713194 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't verify that the chunks moved to the new prototype didn't actually change. I trust you to not try pull off something mischievous :)

When I had this refactoring designed in my head, I arrived at a slightly different API design. I won't talk about it unless you are interested. You got there first. You win :)
Attachment #713194 - Flags: review?(gps) → review+
(Assignee)

Comment 4

6 years ago
Part 1:

https://hg.mozilla.org/services/services-central/rev/baa43b00de2b
Whiteboard: [fixed in services][leave open]
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/baa43b00de2b
Whiteboard: [fixed in services][leave open] → [leave open]
(Assignee)

Comment 6

6 years ago
I'm going to resolve this, because it crosses a release boundary. Will open another bug if necessary.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Target Milestone: --- → mozilla21

Updated

6 years ago
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21

Updated

7 days ago
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.