838879 - Decouple FHR from desktop-specific code

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[Richard Newman [:rnewman]]

Uploading, UX triggering, pref management should all be abstracted in such a way that we can ship only relevant code on Android, and implement the equivalents in Java.

Comment 1

[Richard Newman [:rnewman]]

Shortest term: allow Android to only write prefs, not call a JS function, when enabling or disabling.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 1: split out AbstractHealthReporter. v1

This splits out all of the logic that isn't concerned with uploading and prefs. This is step 1, with subsequent steps being to conditionalize the definition of HealthReporter and its bagheeraclient imports, define a class suitable for use on Android, and conditionally use that instead, and fix tests appropriately.

I was planning to define MOZ_USE_EXTERNAL_HEALTHREPORTER to control this; do you have an opinion?

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 713194 [details] [diff] [review]
Part 1: split out AbstractHealthReporter. v1

Review of attachment 713194 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't verify that the chunks moved to the new prototype didn't actually change. I trust you to not try pull off something mischievous :)

When I had this refactoring designed in my head, I arrived at a slightly different API design. I won't talk about it unless you are interested. You got there first. You win :)

Comment 4

[Richard Newman [:rnewman]]

Part 1:

https://hg.mozilla.org/services/services-central/rev/baa43b00de2b

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/baa43b00de2b

Comment 6

[Richard Newman [:rnewman]]

I'm going to resolve this, because it crosses a release boundary. Will open another bug if necessary.