840129 - Enable FHR on Android

Status: RESOLVED WONTFIX

(Firefox Health Report Graveyard :: Client: Android, defect, P3)

Description

[Richard Newman [:rnewman]]

Including building, repackaging to eliminate desktop-only features.

Comment 1

[Richard Newman [:rnewman]]

Bug 840171 handles cutting down FHR. This bug is just to get it building.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: enable FHR on Android

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 713494 [details] [diff] [review]
enable FHR on Android

Review of attachment 713494 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks fine, but it's a build patch, so let's find a build peer… :)

Comment 4

[Richard Newman [:rnewman]]

Attachment: Part 1: enable. v1

Now with user and patch description.

Comment 5

[Chenxia Liu [:liuche]]

Attachment: Part 1: enable v2

derp, probably need to include the HealthReport module.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 714130 [details] [diff] [review]
Part 1: enable v2

Review of attachment 714130 [details] [diff] [review]:
-----------------------------------------------------------------

This should do the right thing. However, I have reservations about checking in until we know exactly how FHR is failing on Android. There are definitely providers that won't work on Android, etc. IMO we should have a story in place for these before this lands.

Comment 7

[Richard Newman [:rnewman]]

Concur.

Comment 8

[Chenxia Liu [:liuche]]

Attachment: Part 1: enable v3

Removed HealthReport.jsm, because it shouldn't be there.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 718762 [details] [diff] [review]
Part 1: enable v3

Cancelling review until this is ready to land.

Comment 10

[Richard Newman [:rnewman]]

Scope of this will shrink in light of new plan to build almost everything in Java.

Comment 11

[Richard Newman [:rnewman]]

Probably not at all!