Closed
Bug 838916
Opened 11 years ago
Closed 11 years ago
Ensure AppResource matches the data in fireplace flue
Categories
(Marketplace Graveyard :: API, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
2013-03-14
People
(Reporter: robhudson, Assigned: scolville)
References
Details
(Whiteboard: [fireplace] p=2)
mkt/api/resources.py's AppResource should contain the data listed in https://github.com/mozilla/fireplace/blob/master/flue/defaults.py#L34
Updated•11 years ago
|
Assignee: robhudson.mozbugs → nobody
Reporter | ||
Comment 1•11 years ago
|
||
Device types come out bad. We should fix this... "device_types": [ "<django.utils.functional.__proxy__ object at 0x1042f4610>", "<django.utils.functional.__proxy__ object at 0x1042f46d0>" ],
Updated•11 years ago
|
Priority: -- → P2
Whiteboard: p=2
Comment 2•11 years ago
|
||
Also missing * is_packaged * manifest_url * current_version * icons * image_assets * listed_authors * price * ratings * notices (see mkt/site/helpers.py) * support_email * homepage * public_stats * upsell * content_ratings
Updated•11 years ago
|
Whiteboard: p=2 → [fireplace] p=2
Updated•11 years ago
|
Assignee: nobody → scolville
Target Milestone: --- → 2013-03-14
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
I fixed the issue in comment 1 in bug 851948.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Oops, let not close this one.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 6•11 years ago
|
||
We should talk on Wednesday about the data we're sending down and make sure that it's all useful and we're not wasting bytes.
Assignee | ||
Comment 7•11 years ago
|
||
Couple of questions: * How much data is needed for upsell when there's a premium app? * What's the second item in the list with the image_asset url (in the flue data) is it size?
Status: REOPENED → ASSIGNED
Flags: needinfo?
Comment 8•11 years ago
|
||
(In reply to Stuart Colville [:scolville] from comment #7) > Couple of questions: > > * How much data is needed for upsell when there's a premium app? Ideally, the upsell field would contain the app object for the premium version. That would enable us to cache it client-side and have it instaload. > * What's the second item in the list with the image_asset url (in the flue > data) is it size? The second item is the hue value.
Flags: needinfo?
Comment 9•11 years ago
|
||
I don't think notices should be in the list, that's client dependent and its up to the client to interpret how it copes with the various statuses.
Comment 10•11 years ago
|
||
As discussed in the bug, leave out get_webapp_classes_and_notices for now.
Assignee | ||
Comment 11•11 years ago
|
||
https://github.com/mozilla/zamboni/commit/51120ef19f05a58ea83d10fde07e6be43cda75cf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•