838916 - Ensure AppResource matches the data in fireplace flue

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Rob Hudson [:robhudson]]

mkt/api/resources.py's AppResource should contain the data listed in https://github.com/mozilla/fireplace/blob/master/flue/defaults.py#L34

Comment 1

[Rob Hudson [:robhudson]]

Device types come out bad. We should fix this...

  "device_types": [
    "<django.utils.functional.__proxy__ object at 0x1042f4610>", 
    "<django.utils.functional.__proxy__ object at 0x1042f46d0>"
  ],

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Also missing

* is_packaged
* manifest_url
* current_version
* icons
* image_assets
* listed_authors
* price
* ratings
* notices (see mkt/site/helpers.py)
* support_email
* homepage
* public_stats
* upsell
* content_ratings

Comment 4

[Andy McKay]

I fixed the issue in comment 1 in bug 851948.

Comment 5

[Andy McKay]

Oops, let not close this one.

Comment 6

[Matt Basta [:basta]]

We should talk on Wednesday about the data we're sending down and make sure that it's all useful and we're not wasting bytes.

Comment 7

[Stuart Colville [:muffinresearch]]

Couple of questions:

* How much data is needed for upsell when there's a premium app?
* What's the second item in the list with the image_asset url (in the flue data) is it size?

Comment 8

[Matt Basta [:basta]]

(In reply to Stuart Colville [:scolville] from comment #7)
> Couple of questions:
> 
> * How much data is needed for upsell when there's a premium app?

Ideally, the upsell field would contain the app object for the premium version. That would enable us to cache it client-side and have it instaload.

> * What's the second item in the list with the image_asset url (in the flue
> data) is it size?

The second item is the hue value.

Comment 9

[Andy McKay]

I don't think notices should be in the list, that's client dependent and its up to the client to interpret how it copes with the various statuses.

Comment 10

[Andy McKay]

As discussed in the bug, leave out get_webapp_classes_and_notices for now.

Comment 11

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/51120ef19f05a58ea83d10fde07e6be43cda75cf