FOTA updates still don't work

RESOLVED FIXED in Firefox 21

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dhylands, Assigned: dhylands)

Tracking

unspecified
B2G C4 (2jan on)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: QARegressExclude, [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
OK - I screwed up in bug 835210 (/me hangs head in shame)

I didn't know how to test the success path, and my innocuous little change broke the success path.

Marking as tef? since bug 835210 was tef+
(Assignee)

Comment 1

6 years ago
Created attachment 711131 [details] [diff] [review]
Fix try/catch introduced in bug 835210 which caused FOTA updates to still be broken

Finally figured out how to create and test a FOTA update and tested that update was actually applied with this patch.

I tested both storing the update to /data/local/updates/fota and /mnt/sdcard/updates/fota
Attachment #711131 - Flags: review?(marshall)
(Assignee)

Comment 2

6 years ago
Comment on attachment 711131 [details] [diff] [review]
Fix try/catch introduced in bug 835210 which caused FOTA updates to still be broken

Moving let outside the try (as per comment by marshall via email) will upload new patch when ready.
Attachment #711131 - Flags: review?(marshall)
(Assignee)

Comment 3

6 years ago
Created attachment 711135 [details] [diff] [review]
Fix try/catch introduced in bug 835210 which caused FOTA updates to still be broken v2

Moved let outside the try/catch as per email.
Attachment #711135 - Flags: review?(marshall)
(Assignee)

Updated

6 years ago
Attachment #711131 - Attachment is obsolete: true
Attachment #711135 - Flags: review?(marshall) → review+

Comment 4

6 years ago
Issue repros on the OTA for 2/7/13.  When attempting to do an OTA from build 20130205070201 (OTA for 2-5-13) to build 20130207070202 (Current OTA for 2/7/13) it failed on three out or four devices to do on carrier network.  Wifi would work just not AT&T network.  There were four bars showing on carrier network and Data was turned on.  Tested while off as well.  Issue repro.  

Workaround....re-flashed device to update_2-5 OTA and then OTA worked.

Build/Kernel Info that OTA is not working on 
Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/9d977a94f414
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
blocking-b2g: tef? → tef+
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c7435a39f9d1
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/a618e1216a02
status-b2g18: --- → fixed
status-b2g18-v1.0.0: --- → fixed
status-firefox19: --- → wontfix
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
Target Milestone: --- → B2G C4 (2jan on)
status-b2g18-v1.0.1: --- → fixed

Comment 8

6 years ago
Does not make sense to create a regression issue.
Flags: in-moztrap-

Comment 9

6 years ago
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
(Assignee)

Comment 10

6 years ago
You need to create a VARIANT=user or VARIANT=userdebug build.

I just tested with a VARIANT=userdebug.

1 - build it (./build.sh)
2 - flash it (./flash.sh)

3 - Build the fs_config tool
cd into your B2G directory
. ./setup.sh
cd build/tools/fs_config
mm

4 - Build a FOTA update. IMPORTANT: The partition names below are phone specific. If you use the wrong ones, you will almost certainly brick your phone.

DEVICE=unagi
mkdir fota
tools/update-tools/build-flash-fota.py \
    --system-dir out/target/product/${DEVICE}/system \
    --system-fs-type ext4 \
    --system-location /dev/block/mmcblk0p19 \
    --data-fs-type ext4 \
    --data-location /dev/block/mmcblk0p22 \
    --output fota/update.zip

tools/update-tools/build-fota-mar.py \
    --output fota/update.mar fota/update.zip

5 - Deploy the fota update to your phone (requires an adb connection - so make sure that this is enabled first). Also make sure that Wifi is enabled and connected.

tools/update-tools/test-update.py --fota-update fota/update.mar

6 - Once B2G finishes restarting, Go into Settings -> Device Information and do "Check Now"

7 - After about 30 seconds, you should get a notification that a new system update is available. I normally uncheck any apps which need to be updated and just apply the system update. Choose Download.

8 - Once the update has been downloaded and uncompressed, you should get presented with the apply update dialog, choose "Install Now"

The phone should reboot into Android recovery and apply the update. This didn't happen for me when I just tried it. So I can't list the step-by-step required.

So it appears to be broken again.

I did see: 

UpdatePrompt: Rebooting into recovery to apply FOTA update: /mnt/sdcard/updates/fota/update.zip

as the last line of my adb logcat, so it thought it was trying to do that, but it just rebooted back into b2g.
It appears that we don't have the tools to do this on our end in the QA lab here unfortunately.
Whiteboard: QARegressExclude
(Assignee)

Updated

6 years ago
Depends on: 858188

Comment 12

6 years ago
I suspect this affects OTAs but we'll continue on QA side by continuing to test OTA updates.   QA- ing.   Can Dave please ensure that this is resolved and move status from Resolved=>Verified if it's working?  Thanks!
Flags: needinfo?(dhylands)
Whiteboard: QARegressExclude → QARegressExclude, [qa-]
(Assignee)

Comment 13

6 years ago
I tried to verify but it didn't work, so I opened bug 858188
Flags: needinfo?(dhylands)
You need to log in before you can comment on or make changes to this bug.