context-menu overflows depending on the total number of menu items regardless of whether they are hidden or not

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If add-ons add 20 context menu items but only one is visible we should not overflow, but we do.
(Assignee)

Updated

5 years ago
Blocks: 839322
(Assignee)

Updated

5 years ago
Priority: -- → P1
(Assignee)

Updated

5 years ago
Blocks: 839321
(Assignee)

Updated

5 years ago
Assignee: nobody → dtownsend+bugmail
(Assignee)

Updated

5 years ago
No longer blocks: 839321
(Assignee)

Comment 1

5 years ago
Created attachment 711898 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/776

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #711898 - Flags: review?(evold)

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/83b1d8fc326829d71a23c06ed4e0a51b0c72502c
Bug 839318: context-menu should overflow based on the number of visible menu items.

https://github.com/mozilla/addon-sdk/commit/991638d83e13df8f353f3bf473e723df7964745f
Merge pull request #776 from Mossop/bug839318

Fix Bug 839318: context-menu should overflow based on the number of visible menu items r=@erikvold
Attachment #711898 - Flags: review?(evold) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 3

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/056da994cc2802fdc2b23964e4080cb95bfecb1e
Bug 839318: context-menu should overflow based on the number of visible menu items.
(cherry picked from commit 83b1d8fc326829d71a23c06ed4e0a51b0c72502c)

Comment 4

5 years ago
Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/96f521489255504569233720f96811fa00c17c0e
Bug 839318: context-menu should overflow based on the number of visible menu items.
(cherry picked from commit 83b1d8fc326829d71a23c06ed4e0a51b0c72502c)
(cherry picked from commit 056da994cc2802fdc2b23964e4080cb95bfecb1e)

Comment 5

4 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/96f521489255504569233720f96811fa00c17c0e
Bug 839318: context-menu should overflow based on the number of visible menu items.
You need to log in before you can comment on or make changes to this bug.