Closed Bug 839378 Opened 9 years ago Closed 9 years ago

video controls should not modify page DOM

Categories

(Toolkit :: Video/Audio Controls, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

videocontrols.xml has:
                    // Make the <video> element keyboard accessible.
                    this.video.setAttribute("tabindex", 0);

This is bad. We should not be modifying the DOM visible to the page. We need to find another way to do this.

Neil: Is there a better way to do this?
You need to override nsIContent::IsHTMLFocusable for the video element.
Duplicate of this bug: 618737
Attachment #711952 - Flags: review? → review?(enndeakin)
Attachment #711952 - Flags: review?(enndeakin) → review+
https://hg.mozilla.org/mozilla-central/rev/80df535bf5e6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.