839467 - Remove JSContext switching in AdoptNode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

Followup from bug 834732 part 10.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=0883fc3666af

Comment 2

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=a8c0e626d332

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Remove JSContext pushing in AdoptNode. v2

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Remove aCx parameter to CloneAndAdopt. v1

Right now it has to be kept in sync with the nullness of aNewScope. Let's just
rely on the cx stack here and kill the param.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 732539 [details] [diff] [review]
Part 2 - Remove aCx parameter to CloneAndAdopt. v1

Review of attachment 732539 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ -6578,5 @@
>    nsCOMArray<nsINode> nodesWithProperties;
>    rv = nsNodeUtils::Adopt(adoptedNode, sameDocument ? nullptr : mNodeInfoManager,
> -                          // The nsNodeUtils API requires that cx be non-null iff
> -                          // newscope is non-null.
> -                          newScope ? (JSContext*) cx : nullptr,

I was going to ask for a static_cast, but then I realized that this patch nuked that line anyway.

Comment 6

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/96a501b8fb84
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e10b37c57162

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/96a501b8fb84
https://hg.mozilla.org/mozilla-central/rev/e10b37c57162