839718 - ptpb make sure isPrivate works on mobile tabs and window

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Fennec Nightly seems to have per tab private browsing enabled, so the new isPrivate method in bug 828746 ought to work for Fennec.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

`let isPrivate = PrivateBrowsingUtils.isWindowPrivate(browser.contentWindow);`

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#8092

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/792

Pointer to Github pull-request

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 714104 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/792

Few Nit's, would be nice to take care of them, but no need for another review.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/783f354bbc7f37714487a083c645bc82b55cbed3
Bug 839718: isPrivate works on Fennec tabs and windows now

https://github.com/mozilla/addon-sdk/commit/8d95c9e7f03e0845e98f918c4e9bc406ea6dbf15
Bug 839718: updated isWindowPrivate implementation

https://github.com/mozilla/addon-sdk/commit/682a69c089b37059f9a21c5092ad4d6ed9929dc1
Merge pull request #792 from erikvold/839718

Fix Bug 839718: isPrivate works on Fennec r=@Gozala

Comment 5

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/fb5c63d1f421c6aa3b3ef4ca376cf9684236c046
Merge pull request #792 from erikvold/839718

Fix Bug 839718: isPrivate works on Fennec r=@Gozala(cherry picked from commit 682a69c089b37059f9a21c5092ad4d6ed9929dc1)

Conflicts:

	test/test-private-browsing.js