Closed Bug 839788 Opened 13 years ago Closed 12 years ago

Switch Browse button from an <input> to a <button>

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: mounir, Assigned: mounir)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Patch
7.26 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review
It simply prevents loading the complexity of HTMLInputElement when HTMLButtonElement is enough.
Attachment #712141 - Flags: review?(bzbarsky)
Attached patch Patch (obsolete) — — Splinter Review
A huge part of the patch was missing...
Attachment #712141 - Attachment is obsolete: true
Attachment #712141 - Flags: review?(bzbarsky)
Attachment #712142 - Flags: review?(bzbarsky)
Comment on attachment 712142 [details] [diff] [review] Patch But SetTextContent notifies, whereas the attr set did not notify... Notifying under here seems bad.
Attachment #712142 - Flags: review?(bzbarsky) → review-
What about doing this instead of calling SetTextContent(): nsCOMPtr<nsIContent> textContent; nsresult rv = NS_NewTextNode(getter_AddRefs(textContent), aContent->NodeInfo()->NodeInfoManager()); NS_ENSURE_SUCCESS(rv, rv); textContent->SetText(aValue, false); rv = aContent->AppendChildTo(textContent, false); NS_ENSURE_SUCCESS(rv, rv); I mean, do you think it is worth it?
Flags: needinfo?(bzbarsky)
I think we should do that, yes.
Flags: needinfo?(bzbarsky)
Attached patch Patch — — Splinter Review
Attachment #712142 - Attachment is obsolete: true
Attachment #730173 - Flags: review?(bzbarsky)
Comment on attachment 730173 [details] [diff] [review] Patch r=me
Attachment #730173 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0b16aba4df7
Flags: in-testsuite+
Target Milestone: --- → mozilla22
https://tbpl.mozilla.org/php/getParsedLog.php?id=21226758&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226795&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226700&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226197&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226946&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226480&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226081&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226670&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226746&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226826&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226756&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226675&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226978&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225943&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226889&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226485&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226926&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226341&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226659&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225776&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226486&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225850&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226623&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226939&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225725&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226291&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226620&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226845&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226666&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226206&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226967&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225793&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226636&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21224961&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225279&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225078&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225467&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21224835&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225185&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225636&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226220&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226278&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226629&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226661&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226598&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225752&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226235&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226169&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226441&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226867&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226274&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225987&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226265&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225360&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21227014&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226763&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226635&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226617&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226386&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225736&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226042&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226370&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226511&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226685&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21224834&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225607&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226374&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226648&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21224636&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21225335&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226566&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226295&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=21226437&tree=Mozilla-Inbound
Sorry if I missed a few in there, I kept losing my position.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #13) > Yeah, well played... > https://hg.mozilla.org/integration/mozilla-inbound/rev/d2b965a319c6 I forgot to qref before importing the file in my m-i tree :-/ Sorry about that :(
https://hg.mozilla.org/mozilla-central/rev/eff168eefd8c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 859378
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: