83980 - Offline playback of copies to folders with spaces in their name fails

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P1)

Description

[David :Bienvenu]

Because of the way we were storing the copy destinations for offline imap
operations, playback of copies to folders with spaces in the name will fail. I
have a fix for this, I think.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[David :Bienvenu]

add Seth and Navin for review - I was using space to separate the multiple
folder names because I thought spaces were escaped in the uri's - this doesn't
seem to be true anymore, so now I'm using 0x1, which isn't a valid character in
a folder name. Nominating for beta/ship...

Comment 3

[scottputterman]

putting on 0.9.1 radar

Comment 4

[Navin Gupta]

r=naving,  but I am not sure why you have added this comment
       +  // use '^' as the delimiter between folders, and escape '^'

Comment 5

[David :Bienvenu]

whoops, that was an out of date comment - I've replace it with:

  // use 0x1 as the delimiter between folders

Comment 6

[David :Bienvenu]

Attachment: fix with better comment and use #define for separater

Comment 7

[(not reading, please use [e-mail] instead)]

sr=sspitzer

bug #84045 logged about the "space not escaped for imap uris" issue

Comment 8

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the 0.9.1 branch and the trunk.
(on behalf of drivers)

Comment 9

[David :Bienvenu]

fix checked into trunk and branch

Comment 10

[grylchan]

David, I have question about this bug.
I'm not quite sure on the steps to reproduce.
This is what I think you want me to test:
 -online
 -create a folder with space in its name (ie foo bar)
 -go offline
 -copy a message from my inbox to the folder (ie foo bar)
 -go online
 -verify the message has been copied to the destination folder (ie foo bar)?

If this is the case, using
commerical branch builds
2001-06-05-11-0.9.1/ -windows
2001-06-05-04-0.9.1/ -linux
2001-06-05-03-0.9.1/ -mac

When I go online and visit the destination folder, the messages are
not there. The copy fails. While offline, When I finished the copying and then
look at the destination folder, I see the messages. When I go
online they don't appear in that folder anymore. If I log out
and log back in, the messages are still not present in this folder.
Going to another folder and then going back to the destination
folder still does not result in the messages appearing.

If I am correct in my understanding I will reopen the bug. thanks!

Comment 11

[David :Bienvenu]

I tried it on a trunk build - it worked fine. I'll go look at the branch now.

Comment 12

[grylchan]

hmm...tried it with 2001-06-06-06-0.9.1 branch build on win nt 4.0

it looks like it's working. I know it wasn't the messages disappearing
bug 84249 . It looks like downloaded messages don't get copied
over...but that would be bug 78809

I'll test on other platforms and then trunk builds..

It really wasn't working yesterday..sorry for the trouble David.

Comment 13

[David :Bienvenu]

No problem - I'm sure the bug I reported was fixed, but there might be other
intermittent problems.

Comment 14

[grylchan]

Using branch builds
2001-06-06-06-0.9.1/ windows NT 4.0
2001-06-06-11-0.9.1/ linux 2.2 red hat 7.0 
2001-06-06-03-0.9.1/ mac os 9.0.4

Copying messages to folders with spaces
in their names works while you are offline.

Messages are there when you get back online.

Note still having problems w/messages initially
disappearing (84249) and downloaded messages not always
being copied (78809)

Adding keyword vtrunk

marking as verified