test_screenPersistence.html fails when run on Ubuntu because the left hand launcher bar interferes

RESOLVED FIXED in mozilla21

Status

()

defect
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

(Blocks 1 bug)

Trunk
mozilla21
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

while working on converting our tests to run on ubuntu VMs, I found that I was getting a failure in Ubunutu in general.  test_screenPersistence would complain about x=65 and it was expecting x=60:
08:07:12 INFO - 24084 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_screenPersistence.xul | The window should be placed now at x=60px - got 65, expected 60

What happens is inside of Ubuntu there is a launcher bar that lives on the lefthand side of the screen.  This persists by default and our window gets shifted to the edge of it (64 pixels over).
this patch moves the X value from 60 to 70 and this appears to work great.  I am open to any other adjustments you would like to make as well.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #712534 - Flags: review?(bzbarsky)
Comment on attachment 712534 [details] [diff] [review]
adjust window location from 60 to 70 pixels (1.0)

Nah, this was what I was going to suggest.  ;)
Attachment #712534 - Flags: review?(bzbarsky) → review+
Can you not leverage screen.availLeft (and indeed availTop) in some way?
Updated patch to use the leftmost and uppermost pixels available as per comment #3 from Neil.  Tested locally and on the ubuntu vm, will push to try server.
Attachment #712534 - Attachment is obsolete: true
Attachment #712578 - Flags: review?(bzbarsky)
(In reply to Joel Maher (:jmaher) from comment #4)
> Created attachment 712578 [details] [diff] [review]
> adjust window location from 60 to screen.avail* pixels (1.0)
> 
> Updated patch to use the leftmost and uppermost pixels available as per
> comment #3 from Neil.  Tested locally and on the ubuntu vm, will push to try
> server.

You appear to have attached the previous patch again.
It occurred to me that you might want to use 60+screen.avail* otherwise you can't be sure that you're actually having any effect.
Comment on attachment 712578 [details] [diff] [review]
adjust window location from 60 to screen.avail* pixels (1.0)

This is identical to the patch I already reviewed, no?
I had uploaded the wrong patch, this is the correct patch, sorry for the mixup.
Attachment #712578 - Attachment is obsolete: true
Attachment #712578 - Flags: review?(bzbarsky)
Attachment #712714 - Flags: review?(bzbarsky)
Comment on attachment 712714 [details] [diff] [review]
adjust window location from 60 to screen.avail* pixels (2.0)

r=me
Attachment #712714 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/f67abd9e378a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.