840173 - test_screenPersistence.html fails when run on Ubuntu because the left hand launcher bar interferes

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

while working on converting our tests to run on ubuntu VMs, I found that I was getting a failure in Ubunutu in general.  test_screenPersistence would complain about x=65 and it was expecting x=60:
08:07:12 INFO - 24084 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_screenPersistence.xul | The window should be placed now at x=60px - got 65, expected 60

What happens is inside of Ubuntu there is a launcher bar that lives on the lefthand side of the screen.  This persists by default and our window gets shifted to the edge of it (64 pixels over).

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust window location from 60 to 70 pixels (1.0)

this patch moves the X value from 60 to 70 and this appears to work great.  I am open to any other adjustments you would like to make as well.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712534 [details] [diff] [review]
adjust window location from 60 to 70 pixels (1.0)

Nah, this was what I was going to suggest.  ;)

Comment 3

[[e-mail]]

Can you not leverage screen.availLeft (and indeed availTop) in some way?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust window location from 60 to screen.avail* pixels (1.0)

Updated patch to use the leftmost and uppermost pixels available as per comment #3 from Neil.  Tested locally and on the ubuntu vm, will push to try server.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Joel Maher (:jmaher) from comment #4)
> Created attachment 712578 [details] [diff] [review]
> adjust window location from 60 to screen.avail* pixels (1.0)
> 
> Updated patch to use the leftmost and uppermost pixels available as per
> comment #3 from Neil.  Tested locally and on the ubuntu vm, will push to try
> server.

You appear to have attached the previous patch again.

Comment 6

[[e-mail]]

It occurred to me that you might want to use 60+screen.avail* otherwise you can't be sure that you're actually having any effect.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712578 [details] [diff] [review]
adjust window location from 60 to screen.avail* pixels (1.0)

This is identical to the patch I already reviewed, no?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: adjust window location from 60 to screen.avail* pixels (2.0)

I had uploaded the wrong patch, this is the correct patch, sorry for the mixup.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712714 [details] [diff] [review]
adjust window location from 60 to screen.avail* pixels (2.0)

r=me

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f67abd9e378a