840230 - replace nsISupportsArray variable mailnews/base/src/nsMessenger*Integration.*::mFoldersWithNewMail

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

Defined as a variable in:

    mailnews/base/src/nsMessengerUnixIntegration.cpp (View Hg log or Hg annotations)
        line 580 -- mFoldersWithNewMail->Count(&count);
        line 692 -- int32_t indexInNewArray = mFoldersWithNewMail->IndexOf(weakFolder);
        line 707 -- mFoldersWithNewMail->AppendElement(weakFolder);
        line 714 -- mFoldersWithNewMail->RemoveElementAt(indexInNewArray); 
    mailnews/base/src/nsMessengerUnixIntegration.h (View Hg log or Hg annotations)
        line 53 -- nsCOMPtr<nsISupportsArray> mFoldersWithNewMail; // keep track of all the root folders with pending new mail 
    mailnews/base/src/nsMessengerWinIntegration.cpp (View Hg log or Hg annotations)
        line 690 -- mFoldersWithNewMail->Count(&count);
        line 773 -- mFoldersWithNewMail->Count(&count);
        line 885 -- int32_t indexInNewArray = mFoldersWithNewMail->IndexOf(weakFolder);
        line 905 -- mFoldersWithNewMail->InsertElementAt(weakFolder, 0);
        line 921 -- mFoldersWithNewMail->RemoveElementAt(indexInNewArray); 
    mailnews/base/src/nsMessengerWinIntegration.h (View Hg log or Hg annotations)
        line 76 -- nsCOMPtr<nsISupportsArray> mFoldersWithNewMail; // keep track of all the root folders with pending new mail 

Referenced (in 2 files total) in:

    mailnews/base/src/nsMessengerUnixIntegration.cpp (View Hg log or Hg annotations)
        line 107 -- NS_NewISupportsArray(getter_AddRefs(mFoldersWithNewMail));
        line 403 -- ifptr->SetData(mFoldersWithNewMail);
        line 467 -- if (NS_FAILED(mFoldersWithNewMail->Count(&count)))
        line 477 -- weakReference = do_QueryElementAt(mFoldersWithNewMail, i);
        line 574 -- NS_ENSURE_TRUE(mFoldersWithNewMail, NS_ERROR_FAILURE);
        line 588 -- weakReference = do_QueryElementAt(mFoldersWithNewMail, i);
        line 689 -- if (mBiffStateAtom == aProperty && mFoldersWithNewMail) 
    mailnews/base/src/nsMessengerWinIntegration.cpp (View Hg log or Hg annotations)
        line 259 -- NS_NewISupportsArray(getter_AddRefs(mFoldersWithNewMail));
        line 504 -- ifptr->SetData(mFoldersWithNewMail);
        line 694 -- weakReference = do_QueryElementAt(mFoldersWithNewMail, index);
        line 766 -- NS_ENSURE_TRUE(mFoldersWithNewMail, NS_ERROR_FAILURE);
        line 778 -- weakReference = do_QueryElementAt(mFoldersWithNewMail, 0);
        line 882 -- if (mBiffStateAtom == aProperty && mFoldersWithNewMail) 

I have chosen nsIMutableArray for the replacement array because it is passed to a xul dialog and it's JS processing. But maybe there is a better way.

Comment 1

[:aceman]

Attachment: patch

Manually run tested on linux.

Comment 2

[:aceman]

Comment on attachment 712598 [details] [diff] [review]
patch

Compilation fails on Windows:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=031da2ae1103

Will make a new version.

Comment 3

[:aceman]

Attachment: patch v2

This could be better.

Comment 4

[:aceman]

Try build:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=d183b9471c39

Comment 5

[:aceman]

Comment on attachment 713017 [details] [diff] [review]
patch v2

Seems to work.

Comment 6

[[e-mail]]

Comment on attachment 713017 [details] [diff] [review]
patch v2

I couldn't seem to get the new mail alert to open either with or without the patch, so maybe there's something else wrong with my build, but I was able to manually trigger the balloon and icon tooltip with the patch applied, so that's something.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/092b0c4ef3dd