840485 - Test failure "The crash reporter executable is present - got 'false'" in /testInstallation/testBreakpadInstalled.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andreea Matei [:AndreeaMatei]]

Started today on all OS X versions with Nightly fr locale.

Comment 1

[Andreea Matei [:AndreeaMatei]]

Attachment: skip patch

Disabling the test until we find the regression and fix it.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'm able to replicate this locally on Mac OS X 10.8.2 and Nightly with build ID: 20130212031120

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 713083 [details] [diff] [review]
skip patch

Review of attachment 713083 [details] [diff] [review]:
-----------------------------------------------------------------

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/f0cb8723616a (default)

Comment 4

[Andrei Eftimie]

Last good build: 2013-02-11
First bad build: 2013-02-12
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-02-11&enddate=2013-02-12

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This may be another fallout from bug 755724... Could you try to reduce the regression range and if this is a Firefox regression please raise a bug today.

Comment 6

[Andrei Eftimie]

That's exactly what I am doing :)
We should have that figured out today.

Comment 8

[Andrei Eftimie]

Reduced regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=729fe49f9e1f&tochange=784b9beebe90

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is a failure in our test and not in Firefox. So lets get this fixed.

Comment 10

[Andreea Matei [:AndreeaMatei]]

Attachment: fix path

This failure was caused by changes in this changeset: 
http://hg.mozilla.org/mozilla-central/rev/784b9beebe90

It is only on default, where path was changed from Nightly/firefox/ to Nightly/firefox/browser. 'browser' is a new subdirectory, 'chrome' folder was moved in this one. The application crashreporter is in the first location, in 'browser' I found file crashreporter-override (which in Aurora is still on the main folder).

I edited some style guide issues as well.

Reports:
OS X: http://mozmill-crowd.blargon7.com/#/functional/report/f36358d058daf73ddbf78150162deef4
Linux: http://mozmill-crowd.blargon7.com/#/functional/report/f36358d058daf73ddbf78150162e83d8
Win: http://mozmill-crowd.blargon7.com/#/functional/report/f36358d058daf73ddbf78150162e91ea

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 715458 [details] [diff] [review]
fix path

Review of attachment 715458 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/functional/testInstallation/testBreakpadInstalled.js
@@ +24,1 @@
>    controller = mozmill.getBrowserController();

nit: while we are on it, please set it to aModule.controller.

@@ -49,5 @@
>                 "The Breakpad server URL is correct");
>  }
> -
> -setupModule.__force_skip__ = "Bug 840485 - Test failure " +
> -                             "'The crash reporter executable is present - got 'false''";

Don't forget to also update the manifest file.

Comment 12

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

Sorry I missed that. Fixed now.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 715489 [details] [diff] [review]
patch v1

Review of attachment 715489 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/0dd2dc62cc0e (default)

Comment 14

[Andreea Matei [:AndreeaMatei]]

Applies and tests well on Aurora too.

Comment 15

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Transplanted as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ef220ebb2660 (mozilla-aurora)

Comment 16

[mario garbi]

Happened again today on Linux Ubuntu (32bit and 64bit) with Firefox 21:
http://mozmill-ci.blargon7.com/#/functional/report/452ec32f8deec0960aea87aa06f18673
http://mozmill-ci.blargon7.com/#/functional/report/452ec32f8deec0960aea87aa06f1738c

Comment 17

[Andreea Matei [:AndreeaMatei]]

This was due to bug 869242, which Henrik solved now. Tests are passing after  being retriggered.

Comment 18

[Andrei Eftimie]

Failed again several times:
http://mozmill-ci.blargon7.com/#/functional/failure?branch=24.0&platform=Linux&from=2013-05-24&test=%2FtestInstallation%2FtestBreakpadInstalled.js&func=testBreakpadInstalled.js%3A%3AtestBreakpadInstalled

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please stop reopening fixed bugs. That's really not helpful, especially when it was proven it fixed the problem. The new issue is totally different. You/we might want to find better summaries for bugs which explains about their nature to lessen such a confusion.