840625 - install node 0.8.18 on the ubuntu test slaves

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We have node 0.6.12 installed on the ubuntu test slaves, but this doesn't work for the xpcshell test_spdy.js testcase.  

I found the source for node:
http://blog.nodejs.org/2012/01/23/node-v0-7-1/

then ran './configure;make;make install' and had /usr/local/bin/node.

Once this is installed, we need to make sure we are running with MOZ_NODE_PATH=/usr/local/bin/node and the xpcshell tests will pass!

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Looking at nodejs.org, it looks like 0.7.1 is "unstable", which doesnt sound like something we'd want to use in production. 

2012.01.23, Version 0.7.1 (unstable)

On http://nodejs.org/download/, they have 0.8.19 as the "current" (Stable?) version. 


Do the tests pass if we use 0.8.19?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

yes, we should use 0.8.19 as that works just fine.

Comment 3

[Rail Aliiev [:rail]]

0.8.x requires a newer version of v8 library which is not available for 12.04. May need to build that as well.

Comment 4

[Rail Aliiev [:rail]]

FTR, the new package installs node as /usr/bin/nodejs. nodejs-legacy package creates /usr/bin/node -> nodejs simlink.

A scenario to avoid the "legacy" package:

* add reverse symlink on Fedora slaves: ln -s node /usr/bin/nodejs
* deploy the package on Ubuntu slaves. It's safe to deploy the new package even though it removes /usr/bin/node, because UBUNTU SPDY tests aren't enabled for production branches.
* update http://hg.mozilla.org/build/buildbotcustom/file/84568b554fbc/env.py#l80 to point to /usr/bin/nodejs


Another scenario would be:

* Use ensure => "$current_version" for nodejs
* upload the new package
* replace nodejs with nodejs-legacy and ensure=>latest
* enjoy

Comment 5

[Rail Aliiev [:rail]]

Attachment: nodejs-legacy

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 715559 [details] [diff] [review]
nodejs-legacy

I'm confused why nodejs-legacy is a newer version than nodejs?  And why are we using ensure => latest for something we want a specific version of?  It'd be great to have some comments here as to why -legacy.

Comment 7

[Rail Aliiev [:rail]]

Attachment: Add comments

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 715588 [details] [diff] [review]
Add comments

http://hg.mozilla.org/build/puppet/rev/efa81aeb1669

Comment 9

[Rail Aliiev [:rail]]

Attachment: update repo-flag

r=dustin on IRC
http://hg.mozilla.org/build/puppet/rev/50f4cb3071e1

Comment 10

[Rail Aliiev [:rail]]

We ended up with 0.8.18~dfsg1-1mozilla1 (since 0.8.19 hasn't been packaged yet upstream)

Comment 11

[u408661]

It looks like this might have caused a resurgence in bug 749890

Comment 12

[Rail Aliiev [:rail]]

(In reply to Nick Hurley [:hurley] from comment #11)
> It looks like this might have caused a resurgence in bug 749890

Do you have any link to an orange test handy?

It looks like the oranges I'm seeing on m-i are caused by https://bugzilla.mozilla.org/show_bug.cgi?id=771578#c6

Comment 13

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=19925084&tree=Mozilla-Inbound and the misstar from bug 749890 comment 231, https://tbpl.mozilla.org/php/getParsedLog.php?id=19926864&tree=Try, which are both on tst-linux32-ec2-334

Comment 14

[Rail Aliiev [:rail]]

ccing jmaher who may have some ideas.

Comment 15

[Phil Ringnalda (:philor)]

Doesn't Cedar last week know? It's one slave failing the exact same way we did on every slave before this bug landed.

Comment 16

[Rail Aliiev [:rail]]

Bah, tst-linux32-ec2-334 just got nodejs upgraded... :/

Start-Date: 2013-02-20  19:34:29
Commandline: /usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install nodejs-legacy
Install: libv8-3.11.10:i386 (3.11.10.25-1mozilla1, automatic), nodejs-legacy:i386 (0.8.18~dfsg1-1mozilla1)
Upgrade: nodejs:i386 (0.6.12~dfsg1-1ubuntu1, 0.8.18~dfsg1-1mozilla1)
End-Date: 2013-02-20  19:34:36

/me blames himself and bug 839562